Re: [PATCH] target/sh4: Avoid shift into sign bit in update_itlb_use()

[Peter Maydell]

On Tue, 23 Jul 2024 at 18:24, Peter Maydell <peter.maydell@linaro.org> wrote:
>
> In update_itlb_use() the variables or_mask and and_mask are uint8_t,
> which means that in expressions like "and_mask << 24" the usual C
> arithmetic conversions will result in the shift being done as a
> signed int type, and so we will shift into the sign bit. For QEMU
> this isn't undefined behaviour because we use -fwrapv; but we can
> avoid it anyway by using uint32_t types for or_mask and and_mask.
>
> Resolves: Coverity CID 1547628
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

I'll take this via my target-arm queue since I'm doing a
pullreq anyway.

thanks
-- PMM