RE: [PATCH] Hexagon: fix F2_conv_* instructions for negative zero

[ltaylorsimpson]

> -----Original Message-----
> From: Matheus Tavares Bernardino <quic_mathbern@quicinc.com>
> Sent: Sunday, July 28, 2024 11:16 AM
> To: qemu-devel@nongnu.org
> Cc: ltaylorsimpson@gmail.com; bcain@quicinc.com; sidneym@quicinc.com;
> ale@rev.ng; anjo@rev.ng
> Subject: [PATCH] Hexagon: fix F2_conv_* instructions for negative zero
> 
> The implementation for these instructions handles -0 as an invalid float
point
> value, whereas the Hexagon hardware considers it the same as +0 (which is
> valid). Let's fix that and add a regression test.
> 
> Signed-off-by: Matheus Tavares Bernardino <quic_mathbern@quicinc.com>
> ---
>  target/hexagon/op_helper.c | 16 ++++++++--------
>  tests/tcg/hexagon/usr.c    | 10 ++++++++++
>  2 files changed, 18 insertions(+), 8 deletions(-)


You should update the copyright year to 2024 in the files you changed.

Otherwise
Reviewed-by: Taylor Simpson <ltaylorsimpson@gmail.com>