Re: [PATCH 05/18] qapi/crypto: Drop temporary 'prefix'

[Daniel P . Berrangé]

On Tue, Jul 30, 2024 at 10:10:19AM +0200, Markus Armbruster wrote:
> Recent commit "qapi: Smarter camel_to_upper() to reduce need for
> 'prefix'" added two temporary 'prefix' to delay changing the generated
> code.
> 
> Revert them.  This improves QCryptoBlockFormat's generated enumeration
> constant prefix from Q_CRYPTO_BLOCK_FORMAT to QCRYPTO_BLOCK_FORMAT,
> and QCryptoBlockLUKSKeyslotState's from
> Q_CRYPTO_BLOCKLUKS_KEYSLOT_STATE to QCRYPTO_BLOCK_LUKS_KEYSLOT_STATE.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  qapi/crypto.json               |  2 --
>  block/crypto.c                 | 10 +++++-----
>  block/qcow.c                   |  2 +-
>  block/qcow2.c                  | 10 +++++-----
>  crypto/block-luks.c            |  4 ++--
>  crypto/block.c                 |  4 ++--
>  tests/unit/test-crypto-block.c | 14 +++++++-------
>  7 files changed, 22 insertions(+), 24 deletions(-)

Acked-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|