[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] hw/acpi: Add vmclock device
From: |
David Woodhouse |
Subject: |
Re: [PATCH v2] hw/acpi: Add vmclock device |
Date: |
Tue, 30 Jul 2024 20:04:17 +0100 |
User-agent: |
K-9 Mail for Android |
On 30 July 2024 18:53:18 BST, "Michael S. Tsirkin" <mst@redhat.com> wrote:
>We don't want to manually sync headers with Linux.
Indeed. I was briefly tempted to fake it, but figured it might get lost if we
subsequently do run the script to automatically merge from Linux, before the
guest driver is merged there.
>I think Linux abi should live under uapi. When it is there, we can use
>./scripts/update-linux-headers.sh machinery to import it.
This isn't just Linux ABI. It's intended as hypervisor to guest ABI too. In the
fullness of time I'm hoping it'll actually be a virtio header. In the meantime,
best not to overthink it. It's fine in hw/acpi alongside the device itself for
now, I think.