[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH] accel/kvm/kvm-all: Fixes the missing break in vCPU unpark lo
From: |
Salil Mehta |
Subject: |
RE: [PATCH] accel/kvm/kvm-all: Fixes the missing break in vCPU unpark logic |
Date: |
Wed, 31 Jul 2024 08:48:55 +0000 |
Hello,
A quick check and a gentle reminder, has this patch been accepted?
Best regards
Salil.
> From: Igor Mammedov <imammedo@redhat.com>
> Sent: Friday, July 26, 2024 10:34 AM
> To: Salil Mehta <salil.mehta@huawei.com>
>
> On Thu, 25 Jul 2024 15:51:32 +0100
> Salil Mehta <salil.mehta@huawei.com> wrote:
>
> > Loop should exit prematurely on successfully finding out the parked
> > vCPU (struct
> > KVMParkedVcpu) in the 'struct KVMState' maintained
> 'kvm_parked_vcpus'
> > list of parked vCPUs.
> >
> > Fixes: Coverity CID 1558552
> > Fixes: 08c3286822 ("accel/kvm: Extract common KVM vCPU
> > {creation,parking} code")
> > Reported-by: Peter Maydell <peter.maydell@linaro.org>
> > Suggested-by: Peter Maydell <peter.maydell@linaro.org>
> > Message-ID:
> > <CAFEAcA-3_d1c7XSXWkFubD-
> LsW5c5i95e6xxV09r2C9yGtzcdA@mail.gmail.com>
> > Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
>
> Reviewed-by: Igor Mammedov <imammedo@redhat.com>
>
> > ---
> > accel/kvm/kvm-all.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index
> > 0aa4b4624a..c181297f00 100644
> > --- a/accel/kvm/kvm-all.c
> > +++ b/accel/kvm/kvm-all.c
> > @@ -362,6 +362,7 @@ int kvm_unpark_vcpu(KVMState *s, unsigned long
> vcpu_id)
> > QLIST_REMOVE(cpu, node);
> > kvm_fd = cpu->kvm_fd;
> > g_free(cpu);
> > + break;
> > }
> > }
> >
>