[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 02/10] target/i386: Change unavail from u32 to u64
From: |
Paolo Bonzini |
Subject: |
[PULL 02/10] target/i386: Change unavail from u32 to u64 |
Date: |
Wed, 31 Jul 2024 13:17:58 +0200 |
From: Xiong Zhang <xiong.y.zhang@linux.intel.com>
The feature word 'r' is a u64, and "unavail" is a u32, the operation
'r &= ~unavail' clears the high 32 bits of 'r'. This causes many vmx cases
in kvm-unit-tests to fail. Changing 'unavail' from u32 to u64 fixes this
issue.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2442
Fixes: 0b2757412cb1 ("target/i386: drop AMD machine check bits from Intel
CPUID")
Signed-off-by: Xiong Zhang <xiong.y.zhang@linux.intel.com>
Link:
20240730082927.250180-1-xiong.y.zhang@linux.intel.com">https://lore.kernel.org/r/20240730082927.250180-1-xiong.y.zhang@linux.intel.com
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
target/i386/cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 4688d140c2d..ef06da54c63 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -6039,7 +6039,7 @@ uint64_t x86_cpu_get_supported_feature_word(X86CPU *cpu,
FeatureWord w)
{
FeatureWordInfo *wi = &feature_word_info[w];
uint64_t r = 0;
- uint32_t unavail = 0;
+ uint64_t unavail = 0;
if (kvm_enabled()) {
switch (wi->type) {
--
2.45.2
- [PULL 00/10] i386, tests/vm changes for QEMU 9.1-rc, Paolo Bonzini, 2024/07/31
- [PULL 01/10] tests/vm/openbsd: Install tomli, Paolo Bonzini, 2024/07/31
- [PULL 02/10] target/i386: Change unavail from u32 to u64,
Paolo Bonzini <=
- [PULL 03/10] target/i386/cpu: Remove unnecessary SGX feature words checks, Paolo Bonzini, 2024/07/31
- [PULL 04/10] target/i386/cpu: Explicitly express SGX_LC and SGX feature words dependency, Paolo Bonzini, 2024/07/31
- [PULL 05/10] target/i386/cpu: Add dependencies of CPUID 0x12 leaves, Paolo Bonzini, 2024/07/31
- [PULL 07/10] target/i386: Fix typo that assign same value twice, Paolo Bonzini, 2024/07/31
- [PULL 08/10] target/i386: Clean up error cases for vmsr_read_thread_stat(), Paolo Bonzini, 2024/07/31
- [PULL 06/10] target/i386/cpu: Mask off SGX/SGX_LC feature words for non-PC machine, Paolo Bonzini, 2024/07/31
- [PULL 09/10] qemu-vmsr-helper: fix socket loop breakage, Paolo Bonzini, 2024/07/31
- [PULL 10/10] qemu-vmsr-helper: implement --verbose/-v, Paolo Bonzini, 2024/07/31
- Re: [PULL 00/10] i386, tests/vm changes for QEMU 9.1-rc, Richard Henderson, 2024/07/31