[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/arm/mps2-tz.c: fix RX/TX interrupts order
From: |
Peter Maydell |
Subject: |
Re: [PATCH] hw/arm/mps2-tz.c: fix RX/TX interrupts order |
Date: |
Wed, 31 Jul 2024 12:38:18 +0100 |
On Tue, 30 Jul 2024 at 08:32, <marco@palumbi.it> wrote:
>
> From: Marco Palumbi <Marco.Palumbi@tii.ae>
>
> The order of the RX and TX interrupts are swapped.
> This commit fixes the order as per the following documents:
> * https://developer.arm.com/documentation/dai0505/latest/
> * https://developer.arm.com/documentation/dai0521/latest/
> * https://developer.arm.com/documentation/dai0524/latest/
> * https://developer.arm.com/documentation/dai0547/latest/
>
> Signed-off-by: Marco Palumbi <Marco.Palumbi@tii.ae>
Thanks for this patch, I've applied it to my target-arm.next
queue.
I checked the other boards that use the cmsdk UART, and they
all get the tx/rx interrupt order right, so this is the
only place that needed fixing. I suspect that the guest
images I tested didn't care about the separate tx/rx
interrupts and only used the combined irq.
thanks
-- PMM