[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 03/13] tests/avocado/intel_iommu.py: increase timeout
From: |
Cleber Rosa |
Subject: |
Re: [PATCH 03/13] tests/avocado/intel_iommu.py: increase timeout |
Date: |
Wed, 31 Jul 2024 21:02:36 -0400 |
On Mon, Jul 29, 2024 at 6:30 AM Daniel P. Berrangé <berrange@redhat.com> wrote:
>
> On Fri, Jul 26, 2024 at 09:44:28AM -0400, Cleber Rosa wrote:
> > Based on many runs, the average run time for these 4 tests is around
> > 250 seconds, with 320 seconds being the ceiling. In any way, the
> > default 120 seconds timeout is inappropriate in my experience.
> > Let's increase the timeout so these tests get a chance to completion.
>
> A high watermark of over 5 minutes is pretty long for a test.
>
I agree.
> Looking at the test I see it runs
>
> self.ssh_command('dnf -y install numactl-devel')
>
> but then never actually uses the installed package.
>
> I expect that most of the wallclock time here is coming from having
> dnf download all the repodata, 4 times over.
>
Exactly.
> If the intention was to test networking, then replace this with
> something that doesn't have to download 100's of MB of data, then
> see what kind of running time we get before increasing any timeout.
>
>
I was trying not to get in the way of the original test writer.
Eric,
Are you OK with replacing this command for a simpler file transfer?
Any suggestions?
Regards,
- Cleber.
- [PATCH 00/13] Bump Avocado to 103.0 LTS and update tests for compatibility and new features, Cleber Rosa, 2024/07/26
- [PATCH 01/13] tests/avocado: mips: fallback to HTTP given certificate expiration, Cleber Rosa, 2024/07/26
- [PATCH 02/13] tests/avocado: mips: add hint for fetchasset plugin, Cleber Rosa, 2024/07/26
- [PATCH 03/13] tests/avocado/intel_iommu.py: increase timeout, Cleber Rosa, 2024/07/26
- [PATCH 04/13] tests/avocado: add cdrom permission related tests, Cleber Rosa, 2024/07/26
- [PATCH 05/13] tests/avocado: machine aarch64: standardize location and RO access, Cleber Rosa, 2024/07/26
- [PATCH 06/13] tests/avocado: use more distinct names for assets, Cleber Rosa, 2024/07/26
- [PATCH 09/13] tests/avocado/boot_xen.py: fetch kernel during test setUp(), Cleber Rosa, 2024/07/26