[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 01/19] virtio-rng: block max-bytes=0
From: |
Michael S. Tsirkin |
Subject: |
[PULL 01/19] virtio-rng: block max-bytes=0 |
Date: |
Thu, 1 Aug 2024 06:35:14 -0400 |
with max-bytes set to 0, quota is 0 and so device does not work.
block this to avoid user confusion
Message-Id:
<73a89a42d82ec8b47358f25119b87063e4a6ea57.1721818306.git.mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/virtio/virtio-rng.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/virtio/virtio-rng.c b/hw/virtio/virtio-rng.c
index f74efffef7..7cf31da071 100644
--- a/hw/virtio/virtio-rng.c
+++ b/hw/virtio/virtio-rng.c
@@ -184,8 +184,9 @@ static void virtio_rng_device_realize(DeviceState *dev,
Error **errp)
/* Workaround: Property parsing does not enforce unsigned integers,
* So this is a hack to reject such numbers. */
- if (vrng->conf.max_bytes > INT64_MAX) {
- error_setg(errp, "'max-bytes' parameter must be non-negative, "
+ if (vrng->conf.max_bytes == 0 ||
+ vrng->conf.max_bytes > INT64_MAX) {
+ error_setg(errp, "'max-bytes' parameter must be positive, "
"and less than 2^63");
return;
}
--
MST
- [PULL 00/19] virtio,pci,pc: fixes, Michael S. Tsirkin, 2024/08/01
- [PULL 01/19] virtio-rng: block max-bytes=0,
Michael S. Tsirkin <=
- [PULL 02/19] Revert "docs: Document composable SR-IOV device", Michael S. Tsirkin, 2024/08/01
- [PULL 03/19] Revert "virtio-net: Implement SR-IOV VF", Michael S. Tsirkin, 2024/08/01
- [PULL 04/19] Revert "virtio-pci: Implement SR-IOV PF", Michael S. Tsirkin, 2024/08/01
- [PULL 05/19] Revert "pcie_sriov: Allow user to create SR-IOV device", Michael S. Tsirkin, 2024/08/01
- [PULL 06/19] Revert "pcie_sriov: Check PCI Express for SR-IOV PF", Michael S. Tsirkin, 2024/08/01
- [PULL 07/19] Revert "pcie_sriov: Ensure PF and VF are mutually exclusive", Michael S. Tsirkin, 2024/08/01
- [PULL 08/19] Revert "hw/pci: Fix SR-IOV VF number calculation", Michael S. Tsirkin, 2024/08/01
- [PULL 09/19] Revert "pcie_sriov: Register VFs after migration", Michael S. Tsirkin, 2024/08/01
- [PULL 10/19] Revert "pcie_sriov: Remove num_vfs from PCIESriovPF", Michael S. Tsirkin, 2024/08/01
- [PULL 11/19] Revert "pcie_sriov: Release VFs failed to realize", Michael S. Tsirkin, 2024/08/01