Re: [PATCH v2 1/3] target/riscv: Remove redundant insn length check for

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 1/3] target/riscv: Remove redundant insn length check for

From:	Richard Henderson
Subject:	Re: [PATCH v2 1/3] target/riscv: Remove redundant insn length check for zama16b
Date:	Fri, 2 Aug 2024 15:38:47 +1000
User-agent:	Mozilla Thunderbird

On 8/2/24 13:16, LIU Zhiwei wrote:

@@ -47,7 +47,12 @@ static bool trans_fld(DisasContext *ctx, arg_fld *a)
      REQUIRE_FPU;
      REQUIRE_EXT(ctx, RVD);

- if (ctx->cfg_ptr->ext_zama16b && (ctx->cur_insn_len != 2)) {

+    /*
+     * Zama16b applies to loads and stores of no more than MXLEN bits defined
+     * in the F, D, and Q extensions. Otherwise, it falls through to default
+     * MO_ATOM_IFALIGN.
+     */
+    if ((ctx->xl >= MXL_RV64) && (ctx->cfg_ptr->ext_zama16b)) {


I think you meant to add the mxlen check in the next patch,
because you modify this line again.


r~

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v2 0/3] target/riscv: Remove redundant insn length check for zama16b, LIU Zhiwei, 2024/08/01
- [PATCH v2 1/3] target/riscv: Remove redundant insn length check for zama16b, LIU Zhiwei, 2024/08/01
  - Re: [PATCH v2 1/3] target/riscv: Remove redundant insn length check for zama16b, Richard Henderson <=
    - Re: [PATCH v2 1/3] target/riscv: Remove redundant insn length check for zama16b, LIU Zhiwei, 2024/08/02
- [PATCH v2 2/3] target/riscv: Add MXLEN check for F/D/Q applies to zama16b, LIU Zhiwei, 2024/08/01
  - Re: [PATCH v2 2/3] target/riscv: Add MXLEN check for F/D/Q applies to zama16b, Richard Henderson, 2024/08/02
    - Re: [PATCH v2 2/3] target/riscv: Add MXLEN check for F/D/Q applies to zama16b, LIU Zhiwei, 2024/08/02
    - Re: [PATCH v2 2/3] target/riscv: Add MXLEN check for F/D/Q applies to zama16b, Richard Henderson, 2024/08/02
    - Re: [PATCH v2 2/3] target/riscv: Add MXLEN check for F/D/Q applies to zama16b, LIU Zhiwei, 2024/08/02
    - Re: [PATCH v2 2/3] target/riscv: Add MXLEN check for F/D/Q applies to zama16b, LIU Zhiwei, 2024/08/02
    - Re: [PATCH v2 2/3] target/riscv: Add MXLEN check for F/D/Q applies to zama16b, Richard Henderson, 2024/08/02
- [PATCH v2 3/3] target/riscv: Relax fld alignment requirement, LIU Zhiwei, 2024/08/01
  - Re: [PATCH v2 3/3] target/riscv: Relax fld alignment requirement, Richard Henderson, 2024/08/02

Prev by Date: [PATCH] vhost: Add VIRTIO_NET_F_RSC_EXT to vhost feature bits
Next by Date: Re: [PATCH v2 2/3] target/riscv: Add MXLEN check for F/D/Q applies to zama16b
Previous by thread: [PATCH v2 1/3] target/riscv: Remove redundant insn length check for zama16b
Next by thread: Re: [PATCH v2 1/3] target/riscv: Remove redundant insn length check for zama16b
Index(es):
- Date
- Thread