[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 4/4] virtio-net: Add support for USO features
From: |
Michael S. Tsirkin |
Subject: |
Re: [PATCH v2 4/4] virtio-net: Add support for USO features |
Date: |
Thu, 8 Aug 2024 10:47:28 -0400 |
On Thu, Aug 08, 2024 at 10:15:36AM -0400, Peter Xu wrote:
> On Thu, Aug 08, 2024 at 07:12:14AM -0400, Michael S. Tsirkin wrote:
> > This is too big of a hammer. People already use what you call "cross
> > migrate" and have for years. We are not going to stop developing
> > features just because someone suddenly became aware of some such bit.
> > If you care, you will have to work to solve the problem properly -
> > nacking half baked hacks is the only tool maintainers have to make
> > people work on hard problems.
>
> IMHO this is totally different thing. It's not about proposing a new
> feature yet so far, it's about how we should fix a breakage first.
>
> And that's why I think we should fix it even in the simple way first, then
> we consider anything more benefitial from perf side without breaking
> anything, which should be on top of that.
>
> Thanks,
As I said, once the quick hack is merged people stop caring.
Mixing different kernel versions in migration is esoteric enough for
this not to matter to most people. There's no rush I think, address
it properly.
--
MST
- Re: [PATCH v2 4/4] virtio-net: Add support for USO features, (continued)
- Re: [PATCH v2 4/4] virtio-net: Add support for USO features, Michael S. Tsirkin, 2024/08/05
- Re: [PATCH v2 4/4] virtio-net: Add support for USO features, Akihiko Odaki, 2024/08/06
- Re: [PATCH v2 4/4] virtio-net: Add support for USO features, Michael S. Tsirkin, 2024/08/06
- Re: [PATCH v2 4/4] virtio-net: Add support for USO features, Akihiko Odaki, 2024/08/08
- Re: [PATCH v2 4/4] virtio-net: Add support for USO features, Michael S. Tsirkin, 2024/08/08
- Re: [PATCH v2 4/4] virtio-net: Add support for USO features, Akihiko Odaki, 2024/08/08
- Re: [PATCH v2 4/4] virtio-net: Add support for USO features, Michael S. Tsirkin, 2024/08/08
- Re: [PATCH v2 4/4] virtio-net: Add support for USO features, Akihiko Odaki, 2024/08/08
- Re: [PATCH v2 4/4] virtio-net: Add support for USO features, Peter Xu, 2024/08/08
- Re: [PATCH v2 4/4] virtio-net: Add support for USO features, Peter Xu, 2024/08/08
- Re: [PATCH v2 4/4] virtio-net: Add support for USO features,
Michael S. Tsirkin <=
- Re: [PATCH v2 4/4] virtio-net: Add support for USO features, Peter Xu, 2024/08/08
- Re: [PATCH v2 4/4] virtio-net: Add support for USO features, Fabiano Rosas, 2024/08/09
- Re: [PATCH v2 4/4] virtio-net: Add support for USO features, Akihiko Odaki, 2024/08/18
- Re: [PATCH v2 4/4] virtio-net: Add support for USO features, Michael S. Tsirkin, 2024/08/18
- Re: [PATCH v2 4/4] virtio-net: Add support for USO features, Akihiko Odaki, 2024/08/19
- Re: [PATCH v2 4/4] virtio-net: Add support for USO features, Michael S. Tsirkin, 2024/08/11
- Re: [PATCH v2 4/4] virtio-net: Add support for USO features, Akihiko Odaki, 2024/08/18
- Re: [PATCH v2 4/4] virtio-net: Add support for USO features, Akihiko Odaki, 2024/08/01
- Re: [PATCH v2 4/4] virtio-net: Add support for USO features, Michael S. Tsirkin, 2024/08/01
- Re: [PATCH v2 4/4] virtio-net: Add support for USO features, Michael S. Tsirkin, 2024/08/01