[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: CxlCorErrorType member @retry-threshold is undocumented
From: |
Markus Armbruster |
Subject: |
Re: CxlCorErrorType member @retry-threshold is undocumented |
Date: |
Fri, 09 Aug 2024 12:11:10 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Jonathan Cameron <Jonathan.Cameron@Huawei.com> writes:
> On Thu, 08 Aug 2024 19:51:26 +0200
> Markus Armbruster <armbru@redhat.com> wrote:
>
>> Hi Jonathan,
>>
>> You added the type in commit 415442a1b4a (hw/mem/cxl_type3: Add CXL RAS
>> Error Injection Support.) The doc comment is missing a description of
>> @retry-threshold. Can you supply me one? I'm happy to do the actual
>> patch.
>>
> Sorry!
>
> The CXL spec text is
>
> Retry Threshold Hit. (NUM_RETRY >= MAX_NUM_RETRY). Applicable only to 68B
> Flit Mode.
> + a reference to the local retry state machine (LRSM)
>
> So maybe
>
> "Retry threshold hit in the Local Retry State Machine, 68B Flits only."
Is "Local Retry State Machine" a name or a description? The former may
be capitalized, the latter not.