[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 5/7] memory: Clarify owner must not call memory_region_ref
From: |
Peter Xu |
Subject: |
Re: [PATCH v4 5/7] memory: Clarify owner must not call memory_region_ref() |
Date: |
Mon, 26 Aug 2024 11:31:47 -0400 |
On Fri, Aug 23, 2024 at 03:13:10PM +0900, Akihiko Odaki wrote:
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
> include/exec/memory.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/exec/memory.h b/include/exec/memory.h
> index d79415a3b159..6698e9d05eab 100644
> --- a/include/exec/memory.h
> +++ b/include/exec/memory.h
> @@ -1220,6 +1220,7 @@ void memory_region_init(MemoryRegion *mr,
> * memory_region_ref: Add a reference to a memory region
> *
> * This function adds a reference to the owner if present.
> + * The owner must not call this function as it results in a circular
> reference.
> * See docs/devel/memory.rst to know about owner.
> *
> * @mr: the #MemoryRegion
Please consider merging all four doc pre-update patches into one.
Thanks,
--
Peter Xu
- [PATCH v4 0/7] Fix check-qtest-ppc64 sanitizer errors, Akihiko Odaki, 2024/08/23
- [PATCH v4 1/7] migration: Free removed SaveStateEntry, Akihiko Odaki, 2024/08/23
- [PATCH v4 2/7] memory: Do not refer to "memory region's reference count", Akihiko Odaki, 2024/08/23
- [PATCH v4 3/7] memory: Refer to docs/devel/memory.rst for "owner", Akihiko Odaki, 2024/08/23
- [PATCH v4 4/7] memory: Clarify that owner may be missing, Akihiko Odaki, 2024/08/23
- [PATCH v4 5/7] memory: Clarify owner must not call memory_region_ref(), Akihiko Odaki, 2024/08/23
- Re: [PATCH v4 5/7] memory: Clarify owner must not call memory_region_ref(),
Peter Xu <=
- [PATCH v4 6/7] memory: Do not create circular reference with subregion, Akihiko Odaki, 2024/08/23
- Re: [PATCH v4 6/7] memory: Do not create circular reference with subregion, Peter Xu, 2024/08/26
- Re: [PATCH v4 6/7] memory: Do not create circular reference with subregion, Peter Maydell, 2024/08/26
- Re: [PATCH v4 6/7] memory: Do not create circular reference with subregion, Peter Xu, 2024/08/26
- Re: [PATCH v4 6/7] memory: Do not create circular reference with subregion, Akihiko Odaki, 2024/08/27
- Re: [PATCH v4 6/7] memory: Do not create circular reference with subregion, Peter Xu, 2024/08/27
- Re: [PATCH v4 6/7] memory: Do not create circular reference with subregion, Akihiko Odaki, 2024/08/28
- Re: [PATCH v4 6/7] memory: Do not create circular reference with subregion, Peter Xu, 2024/08/28
- Re: [PATCH v4 6/7] memory: Do not create circular reference with subregion, Akihiko Odaki, 2024/08/28
- Re: [PATCH v4 6/7] memory: Do not create circular reference with subregion, Peter Xu, 2024/08/28