[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v6 04/19] migration/multifd: Pass in MultiFDPages_t to file_write
From: |
Fabiano Rosas |
Subject: |
[PATCH v6 04/19] migration/multifd: Pass in MultiFDPages_t to file_write_ramblock_iov |
Date: |
Tue, 27 Aug 2024 14:45:51 -0300 |
We want to stop dereferencing 'pages' so it can be replaced by an
opaque pointer in the next patches.
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Fabiano Rosas <farosas@suse.de>
---
migration/file.c | 3 ++-
migration/file.h | 2 +-
migration/multifd.c | 2 +-
3 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/migration/file.c b/migration/file.c
index 6451a21c86..7f11e26f5c 100644
--- a/migration/file.c
+++ b/migration/file.c
@@ -196,12 +196,13 @@ void file_start_incoming_migration(FileMigrationArgs
*file_args, Error **errp)
}
int file_write_ramblock_iov(QIOChannel *ioc, const struct iovec *iov,
- int niov, RAMBlock *block, Error **errp)
+ int niov, MultiFDPages_t *pages, Error **errp)
{
ssize_t ret = 0;
int i, slice_idx, slice_num;
uintptr_t base, next, offset;
size_t len;
+ RAMBlock *block = pages->block;
slice_idx = 0;
slice_num = 1;
diff --git a/migration/file.h b/migration/file.h
index 9f71e87f74..1a1115f7f1 100644
--- a/migration/file.h
+++ b/migration/file.h
@@ -21,6 +21,6 @@ int file_parse_offset(char *filespec, uint64_t *offsetp,
Error **errp);
void file_cleanup_outgoing_migration(void);
bool file_send_channel_create(gpointer opaque, Error **errp);
int file_write_ramblock_iov(QIOChannel *ioc, const struct iovec *iov,
- int niov, RAMBlock *block, Error **errp);
+ int niov, MultiFDPages_t *pages, Error **errp);
int multifd_file_recv_data(MultiFDRecvParams *p, Error **errp);
#endif
diff --git a/migration/multifd.c b/migration/multifd.c
index 30e5c687d3..640e4450ff 100644
--- a/migration/multifd.c
+++ b/migration/multifd.c
@@ -956,7 +956,7 @@ static void *multifd_send_thread(void *opaque)
if (migrate_mapped_ram()) {
ret = file_write_ramblock_iov(p->c, p->iov, p->iovs_num,
- pages->block, &local_err);
+ pages, &local_err);
} else {
ret = qio_channel_writev_full_all(p->c, p->iov, p->iovs_num,
NULL, 0, p->write_flags,
--
2.35.3
- [PATCH v6 00/19] migration/multifd: Remove multifd_send_state->pages, Fabiano Rosas, 2024/08/27
- [PATCH v6 04/19] migration/multifd: Pass in MultiFDPages_t to file_write_ramblock_iov,
Fabiano Rosas <=
- [PATCH v6 03/19] migration/multifd: Remove pages->allocated, Fabiano Rosas, 2024/08/27
- [PATCH v6 02/19] migration/multifd: Inline page_size and page_count, Fabiano Rosas, 2024/08/27
- [PATCH v6 05/19] migration/multifd: Introduce MultiFDSendData, Fabiano Rosas, 2024/08/27
- [PATCH v6 01/19] migration/multifd: Reduce access to p->pages, Fabiano Rosas, 2024/08/27
- [PATCH v6 06/19] migration/multifd: Make MultiFDPages_t:offset a flexible array member, Fabiano Rosas, 2024/08/27
- [PATCH v6 07/19] migration/multifd: Replace p->pages with an union pointer, Fabiano Rosas, 2024/08/27
- [PATCH v6 08/19] migration/multifd: Move pages accounting into multifd_send_zero_page_detect(), Fabiano Rosas, 2024/08/27
- [PATCH v6 09/19] migration/multifd: Remove total pages tracing, Fabiano Rosas, 2024/08/27
- [PATCH v6 10/19] migration/multifd: Isolate ram pages packet data, Fabiano Rosas, 2024/08/27
- [PATCH v6 11/19] migration/multifd: Don't send ram data during SYNC, Fabiano Rosas, 2024/08/27