[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7 1/4] migration/multifd: Stop changing the packet on recv s
|
From: |
Peter Xu |
|
Subject: |
Re: [PATCH v7 1/4] migration/multifd: Stop changing the packet on recv side |
|
Date: |
Wed, 28 Aug 2024 11:59:17 -0400 |
On Wed, Aug 28, 2024 at 11:56:47AM -0300, Fabiano Rosas wrote:
> As observed by Philippe, the multifd_ram_unfill_packet() function
> currently leaves the MultiFDPacket structure with mixed
> endianness. This is harmless, but ultimately not very clean.
>
> Stop touching the received packet and do the necessary work using
> stack variables instead.
>
> While here tweak the error strings and fix the space before
> semicolons. Also remove the "100 times bigger" comment because it's
> just one possible explanation for a size mismatch and it doesn't even
> match the code.
>
> CC: Philippe Mathieu-Daudé <philmd@linaro.org>
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu