[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/2] vhost-user: add a request-reply lock
From: |
Prasad Pandit |
Subject: |
Re: [PATCH v2 2/2] vhost-user: add a request-reply lock |
Date: |
Thu, 29 Aug 2024 11:09:44 +0530 |
On Wed, 28 Aug 2024 at 16:45, Michael S. Tsirkin <mst@redhat.com> wrote:
> > - Place QEMU_LOCK_GUARD near the vhost_user_write() calls, holding
> > the lock for longer fails some tests during rpmbuild(8).
>
> what do you mean fails rpmbuild? that qemu with this patch can not be
> compiled?
* In V1 of this patch, QEMU_LOCK_GUARD was placed near beginning of
the function. But that caused some unit tests to fail reporting
TIMEOUT errors. In this V2, QEMU_LOCK_GUARD is placed near
vhost_user_write() calls, to reduce the time that lock is held.
* Both (V1 & V2) compile well, but fail at '%check' stage while
running unit tests (on some machines), ie. rpm package is not built.
rpmbuild(8) on F40 machine failed, but koji scratch build with the
same SRPM worked fine. Those scratch builds are shared above. RHEL-9
SRPM built well on RHEL-9 host, but failed to build on F40 machine
reporting failure at '%check' stage of rpmbuild(8).
Thank you.
---
- Prasad
- [PATCH v2 0/2] Postcopy migration and vhost-user errors, Prasad Pandit, 2024/08/28
- [PATCH v2 1/2] vhost: fail device start if iotlb update fails, Prasad Pandit, 2024/08/28
- [PATCH v2 2/2] vhost-user: add a request-reply lock, Prasad Pandit, 2024/08/28
- Re: [PATCH v2 2/2] vhost-user: add a request-reply lock, Michael S. Tsirkin, 2024/08/29
- Re: [PATCH v2 2/2] vhost-user: add a request-reply lock, Prasad Pandit, 2024/08/29
- Re: [PATCH v2 2/2] vhost-user: add a request-reply lock, Michael S. Tsirkin, 2024/08/29
- Re: [PATCH v2 2/2] vhost-user: add a request-reply lock, Peter Xu, 2024/08/29
- Re: [PATCH v2 2/2] vhost-user: add a request-reply lock, Michael S. Tsirkin, 2024/08/29
- Re: [PATCH v2 2/2] vhost-user: add a request-reply lock, Peter Xu, 2024/08/29