qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-9.2] hw/vfio/pci.c: Use correct type in trace_vfio_msix_e


From: Cédric Le Goater
Subject: Re: [PATCH for-9.2] hw/vfio/pci.c: Use correct type in trace_vfio_msix_early_setup()
Date: Mon, 2 Sep 2024 07:59:18 +0200
User-agent: Mozilla Thunderbird

On 8/15/24 15:52, Peter Maydell wrote:
The tracepoint trace_vfio_msix_early_setup() uses "int" for the type
of the table_bar argument, but we use this to print a uint32_t.
Coverity warns that this means that we could end up treating it as a
negative number.

We only use this in printing the value in the tracepoint, so
mishandling it as a negative number would be harmless, but it's
better to use the right type in the tracepoint.  Use uint64_t to
match how we print the table_offset in the vfio_msix_relo()
tracepoint.

Resolves: Coverity CID 1547690
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Applied to vfio-next.

Thanks,

C.






reply via email to

[Prev in Thread] Current Thread [Next in Thread]