qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] kvm/i386: refactor kvm_arch_init and split it into smaller f


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH] kvm/i386: refactor kvm_arch_init and split it into smaller functions
Date: Tue, 3 Sep 2024 15:15:36 +0200
User-agent: Mozilla Thunderbird

On 3/9/24 13:34, Ani Sinha wrote:
kvm_arch_init() enables a lot of vm capabilities. Refactor them into separate
smaller functions. Energy MSR related operations also moved to its own
function. There should be no functional impact.

Signed-off-by: Ani Sinha <anisinha@redhat.com>
---
  target/i386/kvm/kvm.c | 337 ++++++++++++++++++++++++++----------------
  1 file changed, 211 insertions(+), 126 deletions(-)

Nice cleanup, however it would be easier to review as a series
of dumb "extract FOO function" patches instead of a single one.
Up to the maintainer.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]