Re: [PATCH v4 0/9] target/i386: Misc cleanup on KVM PV defs, outdated comments and error handling

[Zhao Liu]

Hi Paolo,

Just a kindly ping.

Thanks,
Zhao

On Wed, Jul 17, 2024 at 12:10:06AM +0800, Zhao Liu wrote:
> Date: Wed, 17 Jul 2024 00:10:06 +0800
> From: Zhao Liu <zhao1.liu@intel.com>
> Subject: [PATCH v4 0/9] target/i386: Misc cleanup on KVM PV defs, outdated
>  comments and error handling
> X-Mailer: git-send-email 2.34.1
> 
> Hi,
> 
> This is my v4 cleanup series. Compared with v3 [1],
>  * Returned kvm_vm_ioctl() directly in kvm_install_msr_filters().
>  * Added a patch (patch 9) to clean up ARRAY_SIZE(msr_handlers).
> 
> 
> Background and Introduction
> ===========================
> 
> This series picks cleanup from my previous kvmclock [2] (as other
> renaming attempts were temporarily put on hold).
> 
> In addition, this series also include the cleanup on a historically
> workaround, recent comment of coco interface [3] and error handling
> corner cases in kvm_arch_init().
> 
> Avoiding the fragmentation of these misc cleanups, I consolidated them
> all in one series and was able to tackle them in one go!
> 
> [1]: 
> https://lore.kernel.org/qemu-devel/20240715044955.3954304-1-zhao1.liu@intel.com/T/
> [2]: 
> https://lore.kernel.org/qemu-devel/20240329101954.3954987-1-zhao1.liu@linux.intel.com/
> [3]: 
> https://lore.kernel.org/qemu-devel/2815f0f1-9e20-4985-849c-d74c6cdc94ae@intel.com/
> 
> Thanks and Best Regards,
> Zhao
> ---
> Zhao Liu (9):
>   target/i386/kvm: Add feature bit definitions for KVM CPUID
>   target/i386/kvm: Remove local MSR_KVM_WALL_CLOCK and
>     MSR_KVM_SYSTEM_TIME definitions
>   target/i386/kvm: Only save/load kvmclock MSRs when kvmclock enabled
>   target/i386/kvm: Save/load MSRs of kvmclock2
>     (KVM_FEATURE_CLOCKSOURCE2)
>   target/i386/kvm: Drop workaround for KVM_X86_DISABLE_EXITS_HTL typo
>   target/i386/confidential-guest: Fix comment of
>     x86_confidential_guest_kvm_type()
>   target/i386/kvm: Clean up return values of MSR filter related
>     functions
>   target/i386/kvm: Clean up error handling in kvm_arch_init()
>   target/i386/kvm: Replace ARRAY_SIZE(msr_handlers) with
>     KVM_MSR_FILTER_MAX_RANGES
> 
>  hw/i386/kvm/clock.c              |   5 +-
>  target/i386/confidential-guest.h |   2 +-
>  target/i386/cpu.h                |  25 +++++++
>  target/i386/kvm/kvm.c            | 113 +++++++++++++++++--------------
>  target/i386/kvm/kvm_i386.h       |   4 +-
>  5 files changed, 92 insertions(+), 57 deletions(-)
> 
> -- 
> 2.34.1
>