[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 33/56] fifo8: introduce head variable for fifo8_peekpop_bufptr()
From: |
Philippe Mathieu-Daudé |
Subject: |
[PULL 33/56] fifo8: introduce head variable for fifo8_peekpop_bufptr() |
Date: |
Wed, 11 Sep 2024 14:13:58 +0200 |
From: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Rather than operate on fifo->head directly, introduce a new head
variable which is set to the value of fifo->head and use it instead.
This is to allow future adjustment of the head position within the
internal FIFO buffer.
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reviewed-by: Octavian Purdila <tavip@google.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20240828122258.928947-3-mark.cave-ayland@ilande.co.uk>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
util/fifo8.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/util/fifo8.c b/util/fifo8.c
index 61bce9d9a0..5faa814a6e 100644
--- a/util/fifo8.c
+++ b/util/fifo8.c
@@ -75,11 +75,12 @@ static const uint8_t *fifo8_peekpop_bufptr(Fifo8 *fifo,
uint32_t max,
uint32_t *numptr, bool do_pop)
{
uint8_t *ret;
- uint32_t num;
+ uint32_t num, head;
assert(max > 0 && max <= fifo->num);
- num = MIN(fifo->capacity - fifo->head, max);
- ret = &fifo->data[fifo->head];
+ head = fifo->head;
+ num = MIN(fifo->capacity - head, max);
+ ret = &fifo->data[head];
if (do_pop) {
fifo->head += num;
--
2.45.2
- [PULL 21/56] target/riscv: Remove the deprecated 'any' CPU type, (continued)
- [PULL 21/56] target/riscv: Remove the deprecated 'any' CPU type, Philippe Mathieu-Daudé, 2024/09/11
- [PULL 31/56] MAINTAINERS: Add myself as a reviewer of VT-d, Philippe Mathieu-Daudé, 2024/09/11
- [PULL 30/56] hw/char/pl011: Rename RX FIFO methods, Philippe Mathieu-Daudé, 2024/09/11
- [PULL 32/56] fifo8: rename fifo8_peekpop_buf() to fifo8_peekpop_bufptr(), Philippe Mathieu-Daudé, 2024/09/11
- [PULL 20/56] seccomp: Remove check for CRIS host, Philippe Mathieu-Daudé, 2024/09/11
- [PULL 29/56] hw/char/pl011: Warn when using disabled transmitter, Philippe Mathieu-Daudé, 2024/09/11
- [PULL 34/56] fifo8: add skip parameter to fifo8_peekpop_bufptr(), Philippe Mathieu-Daudé, 2024/09/11
- [PULL 23/56] hw/char/pl011: Remove unused 'readbuff' field, Philippe Mathieu-Daudé, 2024/09/11
- [PULL 26/56] hw/char/pl011: Split RX/TX path of pl011_reset_fifo(), Philippe Mathieu-Daudé, 2024/09/11
- [PULL 27/56] hw/char/pl011: Extract pl011_write_txdata() from pl011_write(), Philippe Mathieu-Daudé, 2024/09/11
- [PULL 33/56] fifo8: introduce head variable for fifo8_peekpop_bufptr(),
Philippe Mathieu-Daudé <=
- [PULL 28/56] hw/char/pl011: Extract pl011_read_rxdata() from pl011_read(), Philippe Mathieu-Daudé, 2024/09/11
- [PULL 38/56] fifo8: add fifo8_peek_buf() function, Philippe Mathieu-Daudé, 2024/09/11
- [PULL 36/56] fifo8: rename fifo8_pop_buf() to fifo8_peekpop_buf(), Philippe Mathieu-Daudé, 2024/09/11
- [PULL 42/56] tests/unit: Expand test_fifo8_peek_buf_wrap() coverage, Philippe Mathieu-Daudé, 2024/09/11
- [PULL 37/56] fifo8: honour do_pop argument in fifo8_peekpop_buf(), Philippe Mathieu-Daudé, 2024/09/11
- [PULL 39/56] fifo8: introduce fifo8_peek() function, Philippe Mathieu-Daudé, 2024/09/11
- [PULL 43/56] tests/unit: Comment FIFO8 tests, Philippe Mathieu-Daudé, 2024/09/11
- [PULL 44/56] hw/char/escc: convert Sun mouse to use QemuInputHandler, Philippe Mathieu-Daudé, 2024/09/11
- [PULL 35/56] fifo8: replace fifo8_pop_bufptr() with fifo8_peekpop_bufptr() in fifo8_pop_buf(), Philippe Mathieu-Daudé, 2024/09/11
- [PULL 40/56] tests/unit: add test-fifo unit test, Philippe Mathieu-Daudé, 2024/09/11