Re: [PATCH 0/5] Interrupt Remap support for emulated amd viommu

[Shukla, Santosh]

Hi Michael,

On 9/11/2024 1:44 AM, Michael S. Tsirkin wrote:
> On Wed, Sep 04, 2024 at 05:02:52AM -0500, Santosh Shukla wrote:
>> Series adds following feature support for emulated amd vIOMMU
>> 1) Pass Through(PT) mode
>> 2) Interrupt Remapping(IR) mode
>>
>> 1) PT mode
>> Introducing the shared 'nodma' memory region that can be aliased
>> by all the devices in the PT mode. Shared memory with aliasing
>> approach will help run VM faster when lot of devices attached to
>> VM.
>>
>> 2) IR mode
>> Shared IR memory region with aliasing approach proposed for the
>> reason mentioned in 1). Also add support to invalidate Interrupt
>> remaping table(IRT).
>>
>> Series based on f259e4cb8a8b4ef5463326fc214a7d8d7703d5de.
> 
> 
> Fails build on non-kvm:
> 
> https://gitlab.com/mstredhat/qemu/-/jobs/7791357916
> 
> /usr/lib/gcc-cross/i686-linux-gnu/10/../../../../i686-linux-gnu/bin/ld: 
> libqemu-x86_64-softmmu.a.p/hw_i386_amd_iommu.c.o: in function 
> `amdvi_sysbus_realize':
> /builds/mstredhat/qemu/build/../hw/i386/amd_iommu.c:1660: undefined reference 
> to `kvm_enable_x2apic'
> collect2: error: ld returned 1 exit status
> 
Thank you for reporting, Fix in v2.

- Santosh