Re: [PATCH v4 1/5] hw/loongarch: Rename LOONGARCH_MACHINE with LOONGARCH_VIRT_MACHINE

[maobibo]

On 2024/9/13 下午4:02, Markus Armbruster wrote:
> Thomas Huth <thuth@redhat.com> writes:
>
> > On 08/05/2024 05.11, Bibo Mao wrote:
> > > On LoongArch system, there is only virt machine type now, name
> > > LOONGARCH_MACHINE is confused, rename it with LOONGARCH_VIRT_MACHINE.
> > > Machine name about Other real hw boards can be added in future.
> > > Signed-off-by: Bibo Mao <maobibo@loongson.cn>
> > > ---
> > ...
> > > diff --git a/hw/loongarch/virt.c b/hw/loongarch/virt.c
> > > index c0999878df..6619cb52a9 100644
> > > --- a/hw/loongarch/virt.c
> > > +++ b/hw/loongarch/virt.c
> > ...
> > > @@ -1208,7 +1208,6 @@ static void loongarch_class_init(ObjectClass *oc, void 
> > > *data)
> > >        MachineClass *mc = MACHINE_CLASS(oc);
> > >        HotplugHandlerClass *hc = HOTPLUG_HANDLER_CLASS(oc);
> > >    -    mc->desc = "Loongson-3A5000 LS7A1000 machine";
> > >        mc->init = loongarch_init;
> > >        mc->default_ram_size = 1 * GiB;
> > >        mc->default_cpu_type = LOONGARCH_CPU_TYPE_NAME("la464");
> >
> >   Hi!
> >
> > I noticed that the machine now does not have any description anymore, which is 
> > kind of ugly when you list the available machines:
> >
> > $ ./qemu-system-loongarch64 -M help
> > Supported machines are:
> > none                 empty machine
> > virt                 (null) (default)
> >
> > Could you please come up with a new mc->desc for the virt machine?
>
> Formatting a null pointer with %s is actually a crash bug on some
> systems.
Thanks for pointing it out, I will submit a patch to add the description.

Regards
Bibo Ma