qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] hw/i386/pc: Remove vmport value assertion


From: Kamil Szczęk
Subject: Re: [PATCH v2] hw/i386/pc: Remove vmport value assertion
Date: Mon, 16 Sep 2024 14:16:32 +0000

On Wednesday, August 21st, 2024 at 01:11, Kamil Szczęk <kamil@szczek.dev> wrote:
> There is no need for this assertion here, as we only use vmport value
> for equality/inequality checks. This was originally prompted by the
> following Coverity report:
>  >>> CID 1559533: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
>  >>> "pcms->vmport >= 0" is always true regardless of the values of
>  >>> its operands. This occurs as the logical first operand of "&&".
> 
> Signed-off-by: Kamil Szczęk <kamil@szczek.dev>
> Reported-By: Philippe Mathieu-Daudé <philmd@linaro.org>

Hi, just checking in to see if this needs any additional work.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]