[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 02/17] tests/qtest/boot-order-test: Make the machine name mandator
From: |
Thomas Huth |
Subject: |
[PULL 02/17] tests/qtest/boot-order-test: Make the machine name mandatory in this test |
Date: |
Tue, 17 Sep 2024 12:35:25 +0200 |
Let's make sure that we always pass a machine name to the test_boot_orders()
function, so we can check whether the machine is available in the binary
and skip the test in case it is not included in the build.
Message-ID: <20240905191434.694440-4-thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/qtest/boot-order-test.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/qtest/boot-order-test.c b/tests/qtest/boot-order-test.c
index 8f2b6ef05a..c67b8cfe16 100644
--- a/tests/qtest/boot-order-test.c
+++ b/tests/qtest/boot-order-test.c
@@ -31,7 +31,7 @@ static void test_a_boot_order(const char *machine,
uint64_t actual;
QTestState *qts;
- if (machine && !qtest_has_machine(machine)) {
+ if (!qtest_has_machine(machine)) {
g_test_skip("Machine is not available");
return;
}
@@ -107,7 +107,7 @@ static const boot_order_test test_cases_pc[] = {
static void test_pc_boot_order(void)
{
- test_boot_orders(NULL, read_boot_order_pc, test_cases_pc);
+ test_boot_orders("pc", read_boot_order_pc, test_cases_pc);
}
static uint64_t read_boot_order_pmac(QTestState *qts)
--
2.46.0
- [PULL 00/17] s390x and test patches, Thomas Huth, 2024/09/17
- [PULL 01/17] tests/qtest/cdrom-test: Improve the machine detection in the cdrom test, Thomas Huth, 2024/09/17
- [PULL 03/17] tests/qtest/hd-geo-test: Check for availability of "pc" machine before using it, Thomas Huth, 2024/09/17
- [PULL 02/17] tests/qtest/boot-order-test: Make the machine name mandatory in this test,
Thomas Huth <=
- [PULL 05/17] tests/qtest: Disable numa-test if the default machine is not available, Thomas Huth, 2024/09/17
- [PULL 04/17] tests/qtest/meson.build: Add more CONFIG switches checks for the x86 tests, Thomas Huth, 2024/09/17
- [PULL 06/17] .gitlab-ci.d/buildtest: Build most targets in the build-without-defaults job, Thomas Huth, 2024/09/17
- [PULL 07/17] gitlab: fix logic for changing docker tag on stable branches, Thomas Huth, 2024/09/17
- [PULL 08/17] tests/qtest: replace assert(0) with g_assert_not_reached(), Thomas Huth, 2024/09/17
- [PULL 09/17] tests/unit: replace assert(0) with g_assert_not_reached(), Thomas Huth, 2024/09/17
- [PULL 10/17] include/hw/s390x: replace assert(false) with g_assert_not_reached(), Thomas Huth, 2024/09/17
- [PULL 14/17] system: Enable the device aliases for or1k, too, Thomas Huth, 2024/09/17
- [PULL 16/17] tests/functional: Move the mips64el fuloong2e test into the thorough category, Thomas Huth, 2024/09/17
- [PULL 13/17] system: Sort QEMU_ARCH_VIRTIO_PCI definition, Thomas Huth, 2024/09/17