[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 10/34] hw/nvme: replace assert(false) with g_assert_not_reache
From: |
Pierrick Bouvier |
Subject: |
[PATCH v3 10/34] hw/nvme: replace assert(false) with g_assert_not_reached() |
Date: |
Wed, 18 Sep 2024 21:46:17 -0700 |
This patch is part of a series that moves towards a consistent use of
g_assert_not_reached() rather than an ad hoc mix of different
assertion mechanisms.
Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
---
hw/nvme/ctrl.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c
index 9e94a240540..2589e1968ea 100644
--- a/hw/nvme/ctrl.c
+++ b/hw/nvme/ctrl.c
@@ -1816,7 +1816,7 @@ static uint16_t nvme_check_zone_state_for_write(NvmeZone
*zone)
trace_pci_nvme_err_zone_is_read_only(zslba);
return NVME_ZONE_READ_ONLY;
default:
- assert(false);
+ g_assert_not_reached();
}
return NVME_INTERNAL_DEV_ERROR;
@@ -1870,7 +1870,7 @@ static uint16_t nvme_check_zone_state_for_read(NvmeZone
*zone)
trace_pci_nvme_err_zone_is_offline(zone->d.zslba);
return NVME_ZONE_OFFLINE;
default:
- assert(false);
+ g_assert_not_reached();
}
return NVME_INTERNAL_DEV_ERROR;
@@ -4654,7 +4654,7 @@ static uint16_t nvme_io_cmd(NvmeCtrl *n, NvmeRequest *req)
case NVME_CMD_IO_MGMT_SEND:
return nvme_io_mgmt_send(n, req);
default:
- assert(false);
+ g_assert_not_reached();
}
return NVME_INVALID_OPCODE | NVME_DNR;
@@ -7205,7 +7205,7 @@ static uint16_t nvme_admin_cmd(NvmeCtrl *n, NvmeRequest
*req)
case NVME_ADM_CMD_DIRECTIVE_RECV:
return nvme_directive_receive(n, req);
default:
- assert(false);
+ g_assert_not_reached();
}
return NVME_INVALID_OPCODE | NVME_DNR;
--
2.39.5
- [PATCH v3 00/34] Use g_assert_not_reached instead of (g_)assert(0, false), Pierrick Bouvier, 2024/09/19
- [PATCH v3 01/34] hw/acpi: replace assert(0) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 03/34] hw/net: replace assert(0) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 02/34] hw/arm: replace assert(0) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 04/34] migration: replace assert(0) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 05/34] qobject: replace assert(0) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 06/34] target/ppc: replace assert(0) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 07/34] block: replace assert(false) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 08/34] hw/hyperv: replace assert(false) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 09/34] hw/net: replace assert(false) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 10/34] hw/nvme: replace assert(false) with g_assert_not_reached(),
Pierrick Bouvier <=
- [PATCH v3 11/34] hw/pci: replace assert(false) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 12/34] hw/ppc: replace assert(false) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 13/34] migration: replace assert(false) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 15/34] accel/tcg: remove break after g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 14/34] target/i386/kvm: replace assert(false) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 16/34] block: remove break after g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 17/34] hw/acpi: remove break after g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 18/34] hw/net: remove break after g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 19/34] hw/scsi: remove break after g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 21/34] target/arm: remove break after g_assert_not_reached(), Pierrick Bouvier, 2024/09/19