[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 1/7] migration: Remove migrate_cap_set
From: |
dave |
Subject: |
[PATCH v2 1/7] migration: Remove migrate_cap_set |
Date: |
Thu, 19 Sep 2024 14:46:20 +0100 |
From: "Dr. David Alan Gilbert" <dave@treblig.org>
migrate_cap_set has been unused since
18d154f575 ("migration: Remove 'blk/-b' option from migrate commands")
Remove it.
Signed-off-by: Dr. David Alan Gilbert <dave@treblig.org>
Reviewed-by: Fabiano Rosas <farosas@suse.de>
---
migration/options.c | 20 --------------------
migration/options.h | 1 -
2 files changed, 21 deletions(-)
diff --git a/migration/options.c b/migration/options.c
index 147cd2b8fd..9460c5dee9 100644
--- a/migration/options.c
+++ b/migration/options.c
@@ -605,26 +605,6 @@ bool migrate_caps_check(bool *old_caps, bool *new_caps,
Error **errp)
return true;
}
-bool migrate_cap_set(int cap, bool value, Error **errp)
-{
- MigrationState *s = migrate_get_current();
- bool new_caps[MIGRATION_CAPABILITY__MAX];
-
- if (migration_is_running()) {
- error_setg(errp, "There's a migration process in progress");
- return false;
- }
-
- memcpy(new_caps, s->capabilities, sizeof(new_caps));
- new_caps[cap] = value;
-
- if (!migrate_caps_check(s->capabilities, new_caps, errp)) {
- return false;
- }
- s->capabilities[cap] = value;
- return true;
-}
-
MigrationCapabilityStatusList *qmp_query_migrate_capabilities(Error **errp)
{
MigrationCapabilityStatusList *head = NULL, **tail = &head;
diff --git a/migration/options.h b/migration/options.h
index a0bd6edc06..36e7b3723f 100644
--- a/migration/options.h
+++ b/migration/options.h
@@ -58,7 +58,6 @@ bool migrate_tls(void);
/* capabilities helpers */
bool migrate_caps_check(bool *old_caps, bool *new_caps, Error **errp);
-bool migrate_cap_set(int cap, bool value, Error **errp);
/* parameters */
--
2.46.1
- [PATCH v2 0/7] Migration deadcode removal, dave, 2024/09/19
- [PATCH v2 6/7] migration/postcopy: Use uffd helpers, dave, 2024/09/19
- [PATCH v2 2/7] migration: Remove unused migrate_zero_blocks, dave, 2024/09/19
- [PATCH v2 5/7] util/userfaultfd: Return -errno on error, dave, 2024/09/19
- [PATCH v2 1/7] migration: Remove migrate_cap_set,
dave <=
- [PATCH v2 3/7] migration: Deprecate zero-blocks capability, dave, 2024/09/19
- [PATCH v2 4/7] migration: Remove unused socket_send_channel_create_sync, dave, 2024/09/19
- [PATCH v2 7/7] util/userfaultfd: Remove unused uffd_poll_events, dave, 2024/09/19
- Re: [PATCH v2 0/7] Migration deadcode removal, Peter Xu, 2024/09/20