[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 14/27] target/hppa: Add MemOp argument to hppa_get_physical_addres
From: |
Richard Henderson |
Subject: |
[PULL 14/27] target/hppa: Add MemOp argument to hppa_get_physical_address |
Date: |
Sun, 13 Oct 2024 15:12:22 -0700 |
Just add the argument, unused at this point.
Zero is the safe do-nothing value for all callers.
Reviewed-by: Helge Deller <deller@gmx.de>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/hppa/cpu.h | 2 +-
target/hppa/int_helper.c | 2 +-
target/hppa/mem_helper.c | 9 +++++----
target/hppa/op_helper.c | 2 +-
4 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/target/hppa/cpu.h b/target/hppa/cpu.h
index f4e051f176..526855f982 100644
--- a/target/hppa/cpu.h
+++ b/target/hppa/cpu.h
@@ -369,7 +369,7 @@ bool hppa_cpu_tlb_fill(CPUState *cs, vaddr address, int
size,
void hppa_cpu_do_interrupt(CPUState *cpu);
bool hppa_cpu_exec_interrupt(CPUState *cpu, int int_req);
int hppa_get_physical_address(CPUHPPAState *env, vaddr addr, int mmu_idx,
- int type, hwaddr *pphys, int *pprot);
+ int type, MemOp mop, hwaddr *pphys, int *pprot);
void hppa_cpu_do_transaction_failed(CPUState *cs, hwaddr physaddr,
vaddr addr, unsigned size,
MMUAccessType access_type,
diff --git a/target/hppa/int_helper.c b/target/hppa/int_helper.c
index 391f32f27d..58695def82 100644
--- a/target/hppa/int_helper.c
+++ b/target/hppa/int_helper.c
@@ -167,7 +167,7 @@ void hppa_cpu_do_interrupt(CPUState *cs)
vaddr = hppa_form_gva_psw(old_psw, env->iasq_f, vaddr);
t = hppa_get_physical_address(env, vaddr, MMU_KERNEL_IDX,
- 0, &paddr, &prot);
+ 0, 0, &paddr, &prot);
if (t >= 0) {
/* We can't re-load the instruction. */
env->cr[CR_IIR] = 0;
diff --git a/target/hppa/mem_helper.c b/target/hppa/mem_helper.c
index b984f730aa..a386c80fa4 100644
--- a/target/hppa/mem_helper.c
+++ b/target/hppa/mem_helper.c
@@ -197,7 +197,7 @@ static int match_prot_id64(CPUHPPAState *env, uint32_t
access_id)
}
int hppa_get_physical_address(CPUHPPAState *env, vaddr addr, int mmu_idx,
- int type, hwaddr *pphys, int *pprot)
+ int type, MemOp mop, hwaddr *pphys, int *pprot)
{
hwaddr phys;
int prot, r_prot, w_prot, x_prot, priv;
@@ -340,7 +340,7 @@ hwaddr hppa_cpu_get_phys_page_debug(CPUState *cs, vaddr
addr)
mmu_idx = (cpu->env.psw & PSW_D ? MMU_KERNEL_IDX :
cpu->env.psw & PSW_W ? MMU_ABS_W_IDX : MMU_ABS_IDX);
- excp = hppa_get_physical_address(&cpu->env, addr, mmu_idx, 0,
+ excp = hppa_get_physical_address(&cpu->env, addr, mmu_idx, 0, 0,
&phys, &prot);
/* Since we're translating for debugging, the only error that is a
@@ -438,7 +438,8 @@ bool hppa_cpu_tlb_fill(CPUState *cs, vaddr addr, int size,
break;
}
- excp = hppa_get_physical_address(env, addr, mmu_idx, a_prot, &phys, &prot);
+ excp = hppa_get_physical_address(env, addr, mmu_idx, a_prot, 0,
+ &phys, &prot);
if (unlikely(excp >= 0)) {
if (probe) {
return false;
@@ -678,7 +679,7 @@ target_ulong HELPER(lpa)(CPUHPPAState *env, target_ulong
addr)
hwaddr phys;
int prot, excp;
- excp = hppa_get_physical_address(env, addr, MMU_KERNEL_IDX, 0,
+ excp = hppa_get_physical_address(env, addr, MMU_KERNEL_IDX, 0, 0,
&phys, &prot);
if (excp >= 0) {
if (excp == EXCP_DTLB_MISS) {
diff --git a/target/hppa/op_helper.c b/target/hppa/op_helper.c
index 7f79196fff..744325969f 100644
--- a/target/hppa/op_helper.c
+++ b/target/hppa/op_helper.c
@@ -334,7 +334,7 @@ target_ulong HELPER(probe)(CPUHPPAState *env, target_ulong
addr,
}
mmu_idx = PRIV_P_TO_MMU_IDX(level, env->psw & PSW_P);
- excp = hppa_get_physical_address(env, addr, mmu_idx, 0, &phys, &prot);
+ excp = hppa_get_physical_address(env, addr, mmu_idx, 0, 0, &phys, &prot);
if (excp >= 0) {
cpu_restore_state(env_cpu(env), GETPC());
hppa_set_ior_and_isr(env, addr, MMU_IDX_MMU_DISABLED(mmu_idx));
--
2.43.0
- [PULL 01/27] tcg: remove singlestep_enabled from DisasContextBase, (continued)
- [PULL 01/27] tcg: remove singlestep_enabled from DisasContextBase, Richard Henderson, 2024/10/13
- [PULL 02/27] include/exec: Introduce env_cpu_const(), Richard Henderson, 2024/10/13
- [PULL 03/27] linux-user/i386: Emulate orig_ax, Richard Henderson, 2024/10/13
- [PULL 04/27] target/i386/gdbstub: Factor out gdb_get_reg() and gdb_write_reg(), Richard Henderson, 2024/10/13
- [PULL 05/27] target/i386/gdbstub: Expose orig_ax, Richard Henderson, 2024/10/13
- [PULL 06/27] tests/tcg: Run test-proc-mappings.py on i386, Richard Henderson, 2024/10/13
- [PULL 07/27] linux-user/vm86: Fix compilation with Clang, Richard Henderson, 2024/10/13
- [PULL 08/27] accel/tcg: Assert noreturn from write-only page for atomics, Richard Henderson, 2024/10/13
- [PULL 12/27] accel/tcg: Add TCGCPUOps.tlb_fill_align, Richard Henderson, 2024/10/13
- [PULL 13/27] accel/tcg: Use the alignment test in tlb_fill_align, Richard Henderson, 2024/10/13
- [PULL 14/27] target/hppa: Add MemOp argument to hppa_get_physical_address,
Richard Henderson <=
- [PULL 15/27] target/hppa: Perform access rights before protection id check, Richard Henderson, 2024/10/13
- [PULL 10/27] include/exec/memop: Rename get_alignment_bits, Richard Henderson, 2024/10/13
- [PULL 09/27] include/exec/memop: Move get_alignment_bits from tcg.h, Richard Henderson, 2024/10/13
- [PULL 11/27] include/exec/memop: Introduce memop_atomicity_bits, Richard Henderson, 2024/10/13
- [PULL 16/27] target/hppa: Fix priority of T, D, and B page faults, Richard Henderson, 2024/10/13
- [PULL 17/27] target/hppa: Handle alignment faults in hppa_get_physical_address, Richard Henderson, 2024/10/13
- [PULL 18/27] target/hppa: Implement TCGCPUOps.tlb_fill_align, Richard Henderson, 2024/10/13
- [PULL 21/27] target/arm: Pass MemOp to get_phys_addr_gpc, Richard Henderson, 2024/10/13
- [PULL 22/27] target/arm: Pass MemOp to get_phys_addr_nogpc, Richard Henderson, 2024/10/13
- [PULL 26/27] target/arm: Implement TCGCPUOps.tlb_fill_align, Richard Henderson, 2024/10/13