Re: [PATCH] pcie: enable Extended tag field capability

[Marcin Juszkiewicz]

W dniu 17.10.2024 o 18:58, Michael S. Tsirkin pisze:
> > diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c
> > index 4b2f0805c6..54c0f1ec67 100644
> > --- a/hw/pci/pcie.c
> > +++ b/hw/pci/pcie.c
> > @@ -86,7 +86,8 @@ pcie_cap_v1_fill(PCIDevice *dev, uint8_t port, uint8_t type, 
> > uint8_t version)
> >        * Specification, Revision 1.1., or subsequent PCI Express Base
> >        * Specification revisions.
> >        */
> > -    pci_set_long(exp_cap + PCI_EXP_DEVCAP, PCI_EXP_DEVCAP_RBER);
> > +    pci_set_long(exp_cap + PCI_EXP_DEVCAP, PCI_EXP_DEVCAP_RBER |
> > +                 PCI_EXP_DEVCAP_EXT_TAG);
> >   
> >       pci_set_long(exp_cap + PCI_EXP_LNKCAP,
> >                    (port << PCI_EXP_LNKCAP_PN_SHIFT) |
>
> We can't change capabilities unconditionally.
> It needs at least a machine type compat thing.

Thanks for review. Will look how to handle it better then.