[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 07/10] hw/timer/aspeed: Fix interrupt status does not be cleared f
From: |
Cédric Le Goater |
Subject: |
[PULL 07/10] hw/timer/aspeed: Fix interrupt status does not be cleared for AST2600 |
Date: |
Mon, 4 Nov 2024 11:14:58 +0100 |
From: Jamin Lin <jamin_lin@aspeedtech.com>
According to the datasheet of AST2600 description, interrupt status set by HW
and clear to "0" by software writing "1" on the specific bit.
Therefore, if firmware set the specific bit "1" in the interrupt status
register(0x34), the specific bit of "s->irq_sts" should be cleared 0.
Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
Fixes: fadefada4d07 ("aspeed/timer: Add support for IRQ status register on the
AST2600")
Reviewed-by: Andrew Jeffery <andrew@codeconstruct.com.au>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
---
hw/timer/aspeed_timer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/timer/aspeed_timer.c b/hw/timer/aspeed_timer.c
index 5af268ea9ebc..149f7cc5a6aa 100644
--- a/hw/timer/aspeed_timer.c
+++ b/hw/timer/aspeed_timer.c
@@ -580,7 +580,7 @@ static void aspeed_2600_timer_write(AspeedTimerCtrlState
*s, hwaddr offset,
switch (offset) {
case 0x34:
- s->irq_sts &= tv;
+ s->irq_sts &= ~tv;
break;
case 0x3C:
aspeed_timer_set_ctrl(s, s->ctrl & ~tv);
--
2.47.0
- [PULL 00/10] aspeed queue, Cédric Le Goater, 2024/11/04
- [PULL 01/10] hw/arm: enable at24c with aspeed, Cédric Le Goater, 2024/11/04
- [PULL 04/10] hw/arm/aspeed_ast27x0: Avoid hardcoded '256' in IRQ calculation, Cédric Le Goater, 2024/11/04
- [PULL 02/10] hw/sd/sdcard: Fix calculation of size when using eMMC boot partitions, Cédric Le Goater, 2024/11/04
- [PULL 03/10] hw/arm/aspeed_ast27x0: Use bsa.h for PPI definitions, Cédric Le Goater, 2024/11/04
- [PULL 05/10] aspeed/soc: Support RTC for AST2700, Cédric Le Goater, 2024/11/04
- [PULL 07/10] hw/timer/aspeed: Fix interrupt status does not be cleared for AST2600,
Cédric Le Goater <=
- [PULL 06/10] hw/timer/aspeed: Fix coding style, Cédric Le Goater, 2024/11/04
- [PULL 09/10] aspeed: Support create flash devices via command line for AST1030, Cédric Le Goater, 2024/11/04
- [PULL 08/10] hw/sd/aspeed_sdhci: Introduce Capabilities Register 2 for SD slot 0 and 1, Cédric Le Goater, 2024/11/04
- [PULL 10/10] aspeed: Don't set always boot properties of the emmc device, Cédric Le Goater, 2024/11/04
- Re: [PULL 00/10] aspeed queue, Cédric Le Goater, 2024/11/04