[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 08/14] linux-user: Drop image_info.alignment
From: |
Richard Henderson |
Subject: |
[PULL 08/14] linux-user: Drop image_info.alignment |
Date: |
Fri, 15 Nov 2024 12:58:43 -0800 |
This field is write-only. Use only the function-local
variable within load_elf_image.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
linux-user/qemu.h | 1 -
linux-user/elfload.c | 7 +++----
2 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/linux-user/qemu.h b/linux-user/qemu.h
index 895bdd722a..67bc81b149 100644
--- a/linux-user/qemu.h
+++ b/linux-user/qemu.h
@@ -44,7 +44,6 @@ struct image_info {
abi_ulong file_string;
uint32_t elf_flags;
int personality;
- abi_ulong alignment;
bool exec_stack;
/* Generic semihosting knows about these pointers. */
diff --git a/linux-user/elfload.c b/linux-user/elfload.c
index 90e79a01b4..ef9cffbe4a 100644
--- a/linux-user/elfload.c
+++ b/linux-user/elfload.c
@@ -3220,7 +3220,7 @@ static void load_elf_image(const char *image_name, const
ImageSource *src,
* amount of memory to handle that. Locate the interpreter, if any.
*/
loaddr = -1, hiaddr = 0;
- info->alignment = 0;
+ align = 0;
info->exec_stack = EXSTACK_DEFAULT;
for (i = 0; i < ehdr->e_phnum; ++i) {
struct elf_phdr *eppnt = phdr + i;
@@ -3234,7 +3234,7 @@ static void load_elf_image(const char *image_name, const
ImageSource *src,
hiaddr = a;
}
++info->nsegs;
- info->alignment |= eppnt->p_align;
+ align |= eppnt->p_align;
} else if (eppnt->p_type == PT_INTERP && pinterp_name) {
g_autofree char *interp_name = NULL;
@@ -3264,8 +3264,7 @@ static void load_elf_image(const char *image_name, const
ImageSource *src,
load_addr = loaddr;
- align = pow2ceil(info->alignment);
- info->alignment = align;
+ align = pow2ceil(align);
if (pinterp_name != NULL) {
if (ehdr->e_type == ET_EXEC) {
--
2.43.0
- [PULL 00/14] tcg + linux-user patch queue, Richard Henderson, 2024/11/15
- [PULL 02/14] accel/tcg: Fix user-only probe_access_internal plugin check, Richard Henderson, 2024/11/15
- [PULL 01/14] linux-user: Fix setreuid and setregid to use direct syscalls, Richard Henderson, 2024/11/15
- [PULL 03/14] linux-user: Tolerate CONFIG_LSM_MMAP_MIN_ADDR, Richard Henderson, 2024/11/15
- [PULL 04/14] tests/tcg: Test that sigreturn() does not corrupt the signal mask, Richard Henderson, 2024/11/15
- [PULL 05/14] target/i386: fix hang when using slow path for ptw_setl, Richard Henderson, 2024/11/15
- [PULL 08/14] linux-user: Drop image_info.alignment,
Richard Henderson <=
- [PULL 06/14] cpu: ensure we don't call start_exclusive from cpu_exec, Richard Henderson, 2024/11/15
- [PULL 09/14] linux-user/aarch64: Reduce vdso alignment to 4k, Richard Henderson, 2024/11/15
- [PULL 10/14] linux-user/arm: Reduce vdso alignment to 4k, Richard Henderson, 2024/11/15
- [PULL 11/14] linux-user/loongarch64: Reduce vdso alignment to 4k, Richard Henderson, 2024/11/15
- [PULL 12/14] linux-user/ppc: Reduce vdso alignment to 4k, Richard Henderson, 2024/11/15
- [PULL 07/14] linux-user: Honor elf alignment when placing images, Richard Henderson, 2024/11/15
- [PULL 14/14] tcg: Allow top bit of SIMD_DATA_BITS to be set in simd_desc(), Richard Henderson, 2024/11/15
- [PULL 13/14] linux-user/arm: Select vdso for be8 and be32 modes, Richard Henderson, 2024/11/15
- Re: [PULL 00/14] tcg + linux-user patch queue, Peter Maydell, 2024/11/16