[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 07/15] usb-hub: Fix handling port power control messages
From: |
Philippe Mathieu-Daudé |
Subject: |
[PULL 07/15] usb-hub: Fix handling port power control messages |
Date: |
Mon, 18 Nov 2024 13:46:34 +0100 |
From: Guenter Roeck <linux@roeck-us.net>
The ClearPortFeature control message fails for PORT_POWER because there
is no break; at the end of the case statement, causing it to fall through
to the failure handler. Add the missing break; to solve the problem.
Fixes: 1cc403eb21 ("usb-hub: emulate per port power switching")
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20241112170152.217664-11-linux@roeck-us.net>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/usb/dev-hub.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/usb/dev-hub.c b/hw/usb/dev-hub.c
index 06e9537d03..2c3640c705 100644
--- a/hw/usb/dev-hub.c
+++ b/hw/usb/dev-hub.c
@@ -479,6 +479,7 @@ static void usb_hub_handle_control(USBDevice *dev,
USBPacket *p,
usb_hub_port_clear(port, PORT_STAT_SUSPEND);
port->wPortChange = 0;
}
+ break;
default:
goto fail;
}
--
2.45.2
- [PULL 00/15] Misc HW patches for 2024-11-18, Philippe Mathieu-Daudé, 2024/11/18
- [PULL 01/15] vl: fix qemu_validate_options() indention, Philippe Mathieu-Daudé, 2024/11/18
- [PULL 02/15] hw/misc/nrf51_rng: Don't use BIT_MASK() when we mean BIT(), Philippe Mathieu-Daudé, 2024/11/18
- [PULL 03/15] hw/i386/elfboot: allocate "header" in heap, Philippe Mathieu-Daudé, 2024/11/18
- [PULL 04/15] hw/display: factor out the scanout blob to fb conversion, Philippe Mathieu-Daudé, 2024/11/18
- [PULL 05/15] hw/display: check frame buffer can hold blob, Philippe Mathieu-Daudé, 2024/11/18
- [PULL 06/15] MAINTAINERS: Update my email address for COLO, Philippe Mathieu-Daudé, 2024/11/18
- [PULL 07/15] usb-hub: Fix handling port power control messages,
Philippe Mathieu-Daudé <=
- [PULL 08/15] tests/qtest/migration: Fix indentations, Philippe Mathieu-Daudé, 2024/11/18
- [PULL 09/15] hw/sd/sdhci: Fix coding style, Philippe Mathieu-Daudé, 2024/11/18
- [PULL 11/15] Revert "hw/audio/hda: fix memory leak on audio setup", Philippe Mathieu-Daudé, 2024/11/18
- [PULL 10/15] hw/misc/mos6522: Fix bad class definition of the MOS6522 device, Philippe Mathieu-Daudé, 2024/11/18
- [PULL 12/15] hw/audio/hda: fix memory leak on audio setup, Philippe Mathieu-Daudé, 2024/11/18
- [PULL 13/15] hw/net/virtio-net.c: Don't assume IP length field is aligned, Philippe Mathieu-Daudé, 2024/11/18
- [PULL 15/15] hw/watchdog/cmsdk_apb_watchdog: Fix broken link, Philippe Mathieu-Daudé, 2024/11/18
- [PULL 14/15] net: mark struct ip_header as QEMU_PACKED, Philippe Mathieu-Daudé, 2024/11/18
- Re: [PULL 00/15] Misc HW patches for 2024-11-18, Peter Maydell, 2024/11/18