[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 5/6] virtio-net: Initialize hash reporting values
From: |
Akihiko Odaki |
Subject: |
[PATCH v3 5/6] virtio-net: Initialize hash reporting values |
Date: |
Fri, 22 Nov 2024 14:03:11 +0900 |
The specification says hash_report should be set to
VIRTIO_NET_HASH_REPORT_NONE if VIRTIO_NET_F_HASH_REPORT is negotiated
but not configured with VIRTIO_NET_CTRL_MQ_RSS_CONFIG. However,
virtio_net_receive_rcu() instead wrote out the content of the extra_hdr
variable, which is not uninitialized in such a case.
Fix this by zeroing the extra_hdr.
Fixes: e22f0603fb2f ("virtio-net: reference implementation of hash report")
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
hw/net/virtio-net.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index b544d2e91a77..44ea72b50e0e 100644
--- a/hw/net/virtio-net.c
+++ b/hw/net/virtio-net.c
@@ -1911,6 +1911,8 @@ static ssize_t virtio_net_receive_rcu(NetClientState *nc,
const uint8_t *buf,
size_t offset, i, guest_offset, j;
ssize_t err;
+ memset(&extra_hdr, 0, sizeof(extra_hdr));
+
if (n->rss_data.enabled && n->rss_data.enabled_software_rss) {
int index = virtio_net_process_rss(nc, buf, size, &extra_hdr);
if (index >= 0) {
--
2.47.0
- [PATCH v3 0/6] virtio-net fixes, Akihiko Odaki, 2024/11/22
- [PATCH v3 1/6] net: checksum: Convert data to void *, Akihiko Odaki, 2024/11/22
- [PATCH v3 2/6] virtio-net: Fix size check in dhclient workaround, Akihiko Odaki, 2024/11/22
- [PATCH v3 3/6] virtio-net: Do not check for the queue before RSS, Akihiko Odaki, 2024/11/22
- [PATCH v3 4/6] virtio-net: Fix hash reporting when the queue changes, Akihiko Odaki, 2024/11/22
- [PATCH v3 5/6] virtio-net: Initialize hash reporting values,
Akihiko Odaki <=
- [PATCH v3 6/6] virtio-net: Copy received header to buffer, Akihiko Odaki, 2024/11/22
- Re: [PATCH v3 0/6] virtio-net fixes, Lei Yang, 2024/11/25