[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 10/28] tests/functional: honour requested test VM name in QEMUMach
From: |
Alex Bennée |
Subject: |
[PULL 10/28] tests/functional: honour requested test VM name in QEMUMachine |
Date: |
Mon, 25 Nov 2024 15:20:47 +0000 |
From: Daniel P. Berrangé <berrange@redhat.com>
The functional test case class is going to the trouble of passing
around a machine name, but then fails to give this QEMUMachine. As
a result, QEMUMachine will create a completely random name. Since
log file names match the machine name, this results in log files
accumulating over time.
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20241121154218.1423005-11-berrange@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20241121165806.476008-11-alex.bennee@linaro.org>
diff --git a/tests/functional/qemu_test/testcase.py
b/tests/functional/qemu_test/testcase.py
index ca13af244b..f9c9de1166 100644
--- a/tests/functional/qemu_test/testcase.py
+++ b/tests/functional/qemu_test/testcase.py
@@ -164,6 +164,7 @@ def require_device(self, devicename):
def _new_vm(self, name, *args):
vm = QEMUMachine(self.qemu_bin,
+ name=name,
base_temp_dir=self.workdir,
log_dir=self.logdir)
self.log.debug('QEMUMachine "%s" created', name)
--
2.39.5
- [PULL for 9.2-rc2 00/28] testing, plugin and doc fixes, Alex Bennée, 2024/11/25
- [PULL 01/28] tests/functional: fix mips64el test to honour workdir, Alex Bennée, 2024/11/25
- [PULL 03/28] tests/functional: remove "AVOCADO" from env variable name, Alex Bennée, 2024/11/25
- [PULL 02/28] tests/functional: automatically clean up scratch files after tests, Alex Bennée, 2024/11/25
- [PULL 04/28] tests/functional: remove todo wrt avocado.utils.wait_for, Alex Bennée, 2024/11/25
- [PULL 07/28] tests/functional: remove comments talking about avocado, Alex Bennée, 2024/11/25
- [PULL 11/28] tests/functional: enable debug logging for QEMUMachine, Alex Bennée, 2024/11/25
- [PULL 10/28] tests/functional: honour requested test VM name in QEMUMachine,
Alex Bennée <=
- [PULL 05/28] tests/functional: remove leftover :avocado: tags, Alex Bennée, 2024/11/25
- [PULL 09/28] tests/functional: put QEMUMachine logs in testcase log directory, Alex Bennée, 2024/11/25
- [PULL 12/28] tests/functional: logs details of console interaction operations, Alex Bennée, 2024/11/25
- [PULL 06/28] tests/functional: remove obsolete reference to avocado bug, Alex Bennée, 2024/11/25
- [PULL 24/28] rust/pl011: Fix range checks for device ID accesses, Alex Bennée, 2024/11/25
- [PULL 08/28] tests/functional: honour self.workdir in ACPI bits tests, Alex Bennée, 2024/11/25
- [PULL 16/28] tests/functional: remove time.sleep usage from tuxrun tests, Alex Bennée, 2024/11/25
- [PULL 26/28] tests/functional: Convert Aspeed aarch64 SDK tests, Alex Bennée, 2024/11/25
- [PULL 14/28] tests/functional: require non-NULL success_message for console wait, Alex Bennée, 2024/11/25