[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 13/28] tests/functional: don't try to wait for the empty string
From: |
Alex Bennée |
Subject: |
[PULL 13/28] tests/functional: don't try to wait for the empty string |
Date: |
Mon, 25 Nov 2024 15:20:50 +0000 |
From: Daniel P. Berrangé <berrange@redhat.com>
Telling exec_command_wand_wait_for_pattern to wait for the empty
string does not make any conceptual sense, as a check for empty
string will always succeed. It makes even less sense when followed
by a call to wait_for_console_pattern() with a real match.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20241121154218.1423005-14-berrange@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20241121165806.476008-14-alex.bennee@linaro.org>
diff --git a/tests/functional/test_virtio_gpu.py
b/tests/functional/test_virtio_gpu.py
index 441cbdcf2d..d5027487ac 100755
--- a/tests/functional/test_virtio_gpu.py
+++ b/tests/functional/test_virtio_gpu.py
@@ -80,9 +80,8 @@ def test_virtio_vga_virgl(self):
self.wait_for_console_pattern("as init process")
exec_command_and_wait_for_pattern(
- self, "/usr/sbin/modprobe virtio_gpu", ""
+ self, "/usr/sbin/modprobe virtio_gpu", "features: +virgl +edid"
)
- self.wait_for_console_pattern("features: +virgl +edid")
def test_vhost_user_vga_virgl(self):
# FIXME: should check presence of vhost-user-gpu, virgl, memfd etc
--
2.39.5
- [PULL 05/28] tests/functional: remove leftover :avocado: tags, (continued)
- [PULL 05/28] tests/functional: remove leftover :avocado: tags, Alex Bennée, 2024/11/25
- [PULL 09/28] tests/functional: put QEMUMachine logs in testcase log directory, Alex Bennée, 2024/11/25
- [PULL 12/28] tests/functional: logs details of console interaction operations, Alex Bennée, 2024/11/25
- [PULL 06/28] tests/functional: remove obsolete reference to avocado bug, Alex Bennée, 2024/11/25
- [PULL 24/28] rust/pl011: Fix range checks for device ID accesses, Alex Bennée, 2024/11/25
- [PULL 08/28] tests/functional: honour self.workdir in ACPI bits tests, Alex Bennée, 2024/11/25
- [PULL 16/28] tests/functional: remove time.sleep usage from tuxrun tests, Alex Bennée, 2024/11/25
- [PULL 26/28] tests/functional: Convert Aspeed aarch64 SDK tests, Alex Bennée, 2024/11/25
- [PULL 14/28] tests/functional: require non-NULL success_message for console wait, Alex Bennée, 2024/11/25
- [PULL 28/28] tests/functional: Remove sleep workarounds from Aspeed tests, Alex Bennée, 2024/11/25
- [PULL 13/28] tests/functional: don't try to wait for the empty string,
Alex Bennée <=
- [PULL 15/28] tests/functional: rewrite console handling to be bytewise, Alex Bennée, 2024/11/25
- [PULL 23/28] plugins: eradicate qemu-plugins.symbols static file, Alex Bennée, 2024/11/25
- [PULL 17/28] tests/functional: add a QMP backdoor for debugging stalled tests, Alex Bennée, 2024/11/25
- [PULL 18/28] tests/functional: avoid accessing log_filename on earlier failures, Alex Bennée, 2024/11/25
- [PULL 20/28] tests/functional: update the aarch64 tuxrun tests, Alex Bennée, 2024/11/25
- [PULL 25/28] docs: explicitly permit a "commonly known identity" with SoB, Alex Bennée, 2024/11/25
- [PULL 19/28] tests/functional: Convert the Avocado aarch64 tuxrun tests, Alex Bennée, 2024/11/25
- [PULL 22/28] plugins: detect qemu plugin API symbols from header, Alex Bennée, 2024/11/25
- [PULL 27/28] tests/functional: Convert Aspeed arm SDK tests, Alex Bennée, 2024/11/25
- [PULL 21/28] plugins: add missing export for qemu_plugin_num_vcpus, Alex Bennée, 2024/11/25