qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 10/22] tests/qtest/migration: Isolate test initialization


From: Peter Xu
Subject: Re: [PATCH v2 10/22] tests/qtest/migration: Isolate test initialization
Date: Mon, 25 Nov 2024 12:29:26 -0500

On Wed, Nov 13, 2024 at 04:46:18PM -0300, Fabiano Rosas wrote:
> We currently have some environment validation to perform and flags to
> set during the initialization of the tests. To be able to add more
> migration test binaries, we'll need these tasks to be in their own
> function so they can be called from more than one place.
> 
> Move the initialization code to a function and introduce the
> MigrationTestEnv structure to hold the flags that are accessed during
> test registration.
> 
> Make the env object static to avoid have to change all the code to
> pass it around. Similarly with the tmpfs variable, which is used
> extensively.
> 
> Note: I'm keeping the new functions in migration-test.c because they
> are going to be moved in the next patch to the correct place.
> 
> Signed-off-by: Fabiano Rosas <farosas@suse.de>

Reviewed-by: Peter Xu <peterx@redhat.com>

-- 
Peter Xu




reply via email to

[Prev in Thread] Current Thread [Next in Thread]