[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 10/22] tests/qtest/migration: Isolate test initialization
From: |
Peter Xu |
Subject: |
Re: [PATCH v2 10/22] tests/qtest/migration: Isolate test initialization |
Date: |
Mon, 25 Nov 2024 12:29:26 -0500 |
On Wed, Nov 13, 2024 at 04:46:18PM -0300, Fabiano Rosas wrote:
> We currently have some environment validation to perform and flags to
> set during the initialization of the tests. To be able to add more
> migration test binaries, we'll need these tasks to be in their own
> function so they can be called from more than one place.
>
> Move the initialization code to a function and introduce the
> MigrationTestEnv structure to hold the flags that are accessed during
> test registration.
>
> Make the env object static to avoid have to change all the code to
> pass it around. Similarly with the tmpfs variable, which is used
> extensively.
>
> Note: I'm keeping the new functions in migration-test.c because they
> are going to be moved in the next patch to the correct place.
>
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
- [PATCH v2 05/22] tests/qtest/migration: Move bootfile code to its own file, (continued)
- [PATCH v2 05/22] tests/qtest/migration: Move bootfile code to its own file, Fabiano Rosas, 2024/11/13
- [PATCH v2 06/22] tests/qtest/migration: Move qmp helpers to a separate file, Fabiano Rosas, 2024/11/13
- [PATCH v2 07/22] tests/qtest/migration: Rename migration-helpers.c, Fabiano Rosas, 2024/11/13
- [PATCH v2 08/22] tests/qtest/migration: Move ufd_version_check to utils, Fabiano Rosas, 2024/11/13
- [PATCH v2 09/22] tests/qtest/migration: Move kvm_dirty_ring_supported to utils, Fabiano Rosas, 2024/11/13
- [PATCH v2 10/22] tests/qtest/migration: Isolate test initialization, Fabiano Rosas, 2024/11/13
- Re: [PATCH v2 10/22] tests/qtest/migration: Isolate test initialization,
Peter Xu <=
- [PATCH v2 11/22] tests/qtest/migration: Move common test code, Fabiano Rosas, 2024/11/13
- [PATCH v2 12/22] tests/qtest/migration: Split TLS tests from migration-test.c, Fabiano Rosas, 2024/11/13
- [PATCH v2 14/22] tests/qtest/migration: Split postcopy tests, Fabiano Rosas, 2024/11/13
- [PATCH v2 13/22] tests/qtest/migration: Split compression tests from migration-test.c, Fabiano Rosas, 2024/11/13
- [PATCH v2 15/22] tests/qtest/migration: Split file tests, Fabiano Rosas, 2024/11/13