qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 02/22] tests/functional: remove unused system imports


From: Daniel P . Berrangé
Subject: Re: [PATCH 02/22] tests/functional: remove unused system imports
Date: Mon, 2 Dec 2024 09:22:34 +0000
User-agent: Mutt/2.2.13 (2024-03-09)

On Sat, Nov 30, 2024 at 10:59:55AM +0100, Thomas Huth wrote:
> On 29/11/2024 18.31, Daniel P. Berrangé wrote:
> > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> > ---
> >   tests/functional/test_aarch64_sbsaref.py       | 1 -
> >   tests/functional/test_acpi_bits.py             | 1 -
> >   tests/functional/test_m68k_mcf5208evb.py       | 2 --
> >   tests/functional/test_microblaze_s3adsp1800.py | 1 -
> >   tests/functional/test_mips64el_loongson3v.py   | 1 -
> >   tests/functional/test_or1k_sim.py              | 2 --
> >   tests/functional/test_s390x_topology.py        | 1 -
> >   tests/functional/test_sh4_tuxrun.py            | 4 ----
> >   tests/functional/test_sh4eb_r2d.py             | 1 -
> >   tests/functional/test_virtio_version.py        | 2 --
> >   10 files changed, 16 deletions(-)
> 
> Out of curiosity: Is there a way to check for this with a program, or did
> you check it manually?

IIRC, pylint can check this sort of thing, but I performed a horror show
with grep, sed and awk.

We really ought to get black, pylint, flake8, integrated into meson.build,
so we can add checks to python code around the tree more easily.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




reply via email to

[Prev in Thread] Current Thread [Next in Thread]