[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/8] vfio/igd: remove unsupported device ids
From: |
Corvin Köhne |
Subject: |
Re: [PATCH 3/8] vfio/igd: remove unsupported device ids |
Date: |
Mon, 2 Dec 2024 09:13:53 +0000 |
On Sun, 2024-12-01 at 22:30 -0700, Alex Williamson wrote:
> CAUTION: External Email!!
> On Mon, 2 Dec 2024 00:09:33 +0800
> Tomita Moeko <tomitamoeko@gmail.com> wrote:
>
> > Since e433f208973f ("vfio/igd: return an invalid generation for
> > unknown
> > devices"), the default return of igd_gen() was changed to
> > unsupported.
> > There is no need to filter out those unsupported devices.
> >
> > Signed-off-by: Tomita Moeko <tomitamoeko@gmail.com>
> > ---
> > hw/vfio/igd.c | 10 ----------
> > 1 file changed, 10 deletions(-)
> >
> > diff --git a/hw/vfio/igd.c b/hw/vfio/igd.c
> > index b449316ec0..8f300498e4 100644
> > --- a/hw/vfio/igd.c
> > +++ b/hw/vfio/igd.c
> > @@ -64,16 +64,6 @@ static int igd_gen(VFIOPCIDevice *vdev)
> > }
> >
> > switch (vdev->device_id & 0xff00) {
> > - /* Old, untested, unavailable, unknown */
> > - case 0x0000:
> > - case 0x2500:
> > - case 0x2700:
> > - case 0x2900:
> > - case 0x2a00:
> > - case 0x2e00:
> > - case 0x3500:
> > - case 0xa000:
> > - return -1;
> > /* SandyBridge, IvyBridge, ValleyView, Haswell */
> > case 0x0100:
> > case 0x0400:
>
> Reviewed-by: Alex Williamson <alex.williamson@redhat.com>
>
>
Reviewed-by: Corvin Köhne <c.koehne@beckhoff.com>
disable-disclaimer-BADE
signature.asc
Description: This is a digitally signed message part
- Re: [PATCH 7/8] vfio/igd: emulate BDSM in mmio bar0 for gen 6-10 devices, (continued)
- [PATCH 8/8] vfio/igd: add x-igd-gms option back to set DSM region size for guest, Tomita Moeko, 2024/12/01
- [PATCH 6/8] vfio/igd: emulate GGC register in mmio bar0, Tomita Moeko, 2024/12/01
- [PATCH 3/8] vfio/igd: remove unsupported device ids, Tomita Moeko, 2024/12/01
- [PATCH 4/8] vfio/igd: align generation with i915 kernel driver, Tomita Moeko, 2024/12/01
- [PATCH 2/8] vfio/igd: canonicalize memory size calculations, Tomita Moeko, 2024/12/01
- [PATCH 1/8] vfio/igd: fix GTT stolen memory size calculation for gen 7, Tomita Moeko, 2024/12/01