Re: [PATCH 5/7] [BCM2835 AUX 5/7] Suffix constants

[Peter Maydell]

On Sun, 17 Nov 2024 at 23:02, Ioan-Cristian CÎRSTEA
<jean.christian.cirstea@gmail.com> wrote:
>
> The constants defined through the preprocessor must be unsigned. Also,
> unsigned integer constants are consistent across different bases (see
> section 6.4.4.1 of the C99 standard draft).
>
> Signed-off-by: Ioan-Cristian CÎRSTEA <ioan-cristian.cirstea@tutanota.com>
> ---
>  hw/char/bcm2835_aux.c | 52 +++++++++++++++++++++----------------------
>  1 file changed, 26 insertions(+), 26 deletions(-)

I don't understand what this is trying to fix;
can you explain in more detail, please?

Some of these constants are ones you've added in earlier
patches in this series. If they need the U suffix for
correct behaviour then you should add them with the
U suffix initially, not add without and then change here.

thanks
-- PMM