qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1 3/4] migration: refactor ram_save_target_page functions


From: Prasad Pandit
Subject: Re: [PATCH v1 3/4] migration: refactor ram_save_target_page functions
Date: Tue, 3 Dec 2024 11:10:04 +0530

Hello Fabiano,

On Mon, 2 Dec 2024 at 19:42, Fabiano Rosas <farosas@suse.de> wrote:
> >   ...multifd_send/_recv_sync_main();    <= do the 'flush' and
> > 'sync' mean the same thing here?
>
> No, that patch is indeed inconsistent in the terminology, good point.
> Well, flush and sync are not reserved terms, we can use them however we
> see fit. As long as it's consistent, of course.
>

* It'll help to define what 'flush' does and what 'sync' does in the
Multifd context and how they differ from each other. Maybe here or
code comments or both places or somewhere. Knowing their intended
meaning will help while reading code, reviewing patches and also avoid
confusion.

Thank you.
---
  - Prasad




reply via email to

[Prev in Thread] Current Thread [Next in Thread]