Re: [PATCH v2 0/3 for 9.2] hw/virtio: fix crash in virtio-balloon and test it

[Michael S. Tsirkin]

On Mon, Dec 02, 2024 at 08:50:55PM +0100, Philippe Mathieu-Daudé wrote:
> Hi,
> 
> On 2/12/24 18:05, David Hildenbrand wrote:
> > On 29.11.24 14:55, Daniel P. Berrangé wrote:
> > > See patch 1 for the background info on the problem
> > > 
> > > Changed in v2:
> > > 
> > >   * Add qtest coverage for the crash scenario
> > > 
> > > Daniel P. Berrangé (3):
> > >    hw/virtio: fix crash in processing balloon stats
> > >    tests/qtest: drop 'fuzz-' prefix from virtio-balloon test
> > >    tests/qtest: add test for querying balloon guest stats
> > > 
> > >   hw/virtio/virtio-balloon.c             | 16 +++++++-
> > >   tests/qtest/fuzz-virtio-balloon-test.c | 37 -----------------
> > >   tests/qtest/meson.build                |  2 +-
> > >   tests/qtest/virtio-balloon-test.c      | 57 ++++++++++++++++++++++++++
> > >   4 files changed, 73 insertions(+), 39 deletions(-)
> > >   delete mode 100644 tests/qtest/fuzz-virtio-balloon-test.c
> > >   create mode 100644 tests/qtest/virtio-balloon-test.c
> > > 
> > 
> > @MST, do you want to queue this or should I do it? We should get this
> > into 9.2.
> 
> I'm preparing a PR for tomorrow; I included this series
> amending:
> 
> -- >8 --
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 2b1c4abed65..51e3a79b6bb 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2227,6 +2227,7 @@ F: hw/virtio/virtio-balloon*.c
>  F: include/hw/virtio/virtio-balloon.h
>  F: system/balloon.c
>  F: include/sysemu/balloon.h
> +F: tests/qtest/virtio-balloon-test.c
> 
>  virtio-9p
>  M: Greg Kurz <groug@kaod.org>
> ---
> 
> Tell me if it isn't appropriate and I'll drop it.
> 
> Regards,
> 
> Phil.


Go ahead.

Series:
Acked-by: Michael S. Tsirkin <mst@redhat.com>