Re: [PATCH v4 08/15] acpi/ghes: make the GHES record generation more generic

[Mauro Carvalho Chehab]

Em Tue, 3 Dec 2024 12:42:32 +0100
Igor Mammedov <imammedo@redhat.com> escreveu:

> > +    /*
> > +     * Clear the Read Ack Register, OSPM will write it to 1 when  
>                                                  ^^^^^^^^^^^^^ typo?
> > +     * it acknowledges this error.
> > +     */

Yes. I'll add this hunk there:

diff --git a/hw/acpi/ghes.c b/hw/acpi/ghes.c
index 68fb30c2d5c1..4b5332f8c667 100644
--- a/hw/acpi/ghes.c
+++ b/hw/acpi/ghes.c
@@ -403,8 +403,8 @@ void ghes_record_cper_errors(const void *cper, size_t len,
 
     read_ack_register = cpu_to_le64(0);
     /*
-     * Clear the Read Ack Register, OSPM will write it to 1 when
-     * it acknowledges this error.
+     * Clear the Read Ack Register, OSPM will write 1 to this register when
+     * it acknowledges the error.
      */
     cpu_physical_memory_write(read_ack_register_addr,
         &read_ack_register, sizeof(uint64_t));


Thanks,
Mauro