Re: [PATCH v2 4/9] vfio/igd: add Gemini Lake and Comet Lake device ids

[Corvin Köhne]

On Tue, 2024-12-03 at 21:35 +0800, Tomita Moeko wrote:
> CAUTION: External Email!!
> Both Gemini Lake and Comet Lake are gen 9 devices. Many user reports
> on internet shows legacy mode of igd passthrough works as qemu treats
> them as gen 8 devices by default before e433f208973f ("vfio/igd:
> return an invalid generation for unknown devices").
> 

Are there any user reports you can link to in the commit message?

> Signed-off-by: Tomita Moeko <tomitamoeko@gmail.com>
> ---
>  hw/vfio/igd.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/hw/vfio/igd.c b/hw/vfio/igd.c
> index b5bfdc6580..7f389de7ac 100644
> --- a/hw/vfio/igd.c
> +++ b/hw/vfio/igd.c
> @@ -80,8 +80,10 @@ static int igd_gen(VFIOPCIDevice *vdev)
>      case 0x2200:    /* Cherryview */
>          return 8;
>      case 0x1900:    /* Skylake */
> +    case 0x3100:    /* Gemini Lake */
>      case 0x5900:    /* Kaby Lake */
>      case 0x3e00:    /* Coffee Lake */
> +    case 0x9B00:    /* Comet Lake */
>          return 9;
>      case 0x4500:    /* Elkhart Lake */
>          return 11;

Reviewed-by: Corvin Köhne <c.koehne@beckhoff.com>

signature.asc
Description: This is a digitally signed message part