RE: [PATCH v2 3/6] hw:sdhci: Introduce a new "capareg" class member to set the different Capability Registers.

[Jamin Lin]

Hi Philippe,

> Subject: Re: [PATCH v2 3/6] hw:sdhci: Introduce a new "capareg" class member
> to set the different Capability Registers.
> 
> On 3/12/24 03:14, Jamin Lin via wrote:
> > Currently, it set the hardcode value of capability registers to all
> > ASPEED SOCs However, the value of capability registers should be
> > different for all ASPEED SOCs. For example: the bit 28 of the
> > Capability Register 1 should be 1 for 64-bits System Bus support for 
> > AST2700.
> >
> > Introduce a new "capareg" class member whose data type is uint_64 to
> > set the different Capability Registers to all ASPEED SOCs.
> >
> > The value of Capability Register is "0x0000000001e80080" for AST2400
> > and AST2500. The value of Capability Register is "0x0000000701f80080" for
> AST2600.
> >
> > Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
> > ---
> >   hw/arm/aspeed_ast2400.c      |  3 +-
> >   hw/arm/aspeed_ast2600.c      |  7 ++--
> >   hw/sd/aspeed_sdhci.c         | 72
> +++++++++++++++++++++++++++++++-----
> >   include/hw/sd/aspeed_sdhci.h | 12 +++++-
> >   4 files changed, 78 insertions(+), 16 deletions(-)
> 
> 
> > -DEFINE_TYPES(aspeed_sdhci_types)
> 
> > +type_init(aspeed_sdhci_register_types);
> 
> Please do not re-introduce type_init() calls. We want to replace them by
> DEFINE_TYPES().

Thanks for review and suggestion.
Will fix it.

Jamin