[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH RFC 00/11] migration/block: disk activation rewrite
From: |
Peter Xu |
Subject: |
Re: [PATCH RFC 00/11] migration/block: disk activation rewrite |
Date: |
Wed, 4 Dec 2024 12:25:42 -0500 |
On Tue, Dec 03, 2024 at 07:51:27PM -0500, Peter Xu wrote:
> migration/block: Merge block reactivations for fail/cancel
> migration/block: Extend the migration_block_* API to dest side
> migration/block: Apply the migration_block_* API to postcopy
I just noticed these three patches cannot be separate, because right after
we introduce a flag to cache disk activation status, it will need to apply
to all the code or inconsistency can happen if someone applies one of the
patches, for example.
I also overlooked that we must take qmp_cont() into the picture too, so
that will also need to use the API so the flag will be consistent.
So in the next version I'll squash the three patches into one, and also use
the new API in qmp_cont(), so the status flag should always be consistent.
Again, to block layer developers: please help if any of you know how to
make bdrv_inactivate_all() safe to be called on top of inactivated disks,
or any reasoning on why it mustn't. It could be very helpful.
--
Peter Xu
- [PATCH RFC 06/11] migration/block: Extend the migration_block_* API to dest side, (continued)
- [PATCH RFC 06/11] migration/block: Extend the migration_block_* API to dest side, Peter Xu, 2024/12/03
- [PATCH RFC 05/11] migration/block: Merge block reactivations for fail/cancel, Peter Xu, 2024/12/03
- [PATCH RFC 04/11] migration/block: Fix possible race with block_inactive, Peter Xu, 2024/12/03
- [PATCH RFC 08/11] tests/qtest/migration: Move more code under only_target, Peter Xu, 2024/12/03
- [PATCH RFC 10/11] tests/qtest/migration: Support cleaning up only one side of migration, Peter Xu, 2024/12/03
- [PATCH RFC 09/11] tests/qtest/migration: Don't use hardcoded strings for -serial, Peter Xu, 2024/12/03
- [PATCH RFC 07/11] migration/block: Apply the migration_block_* API to postcopy, Peter Xu, 2024/12/03
- [PATCH RFC 11/11] tests/qtest/migration: Test successive migrations, Peter Xu, 2024/12/03
- Re: [PATCH RFC 00/11] migration/block: disk activation rewrite,
Peter Xu <=