[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 05/24] migration: Add MIG_CMD_SWITCHOVER_START and its loa
From: |
Peter Xu |
Subject: |
Re: [PATCH v3 05/24] migration: Add MIG_CMD_SWITCHOVER_START and its load handler |
Date: |
Wed, 4 Dec 2024 16:29:18 -0500 |
On Sun, Nov 17, 2024 at 08:20:00PM +0100, Maciej S. Szmigiero wrote:
> diff --git a/migration/colo.c b/migration/colo.c
> index 9590f281d0f1..a75c2c41b464 100644
> --- a/migration/colo.c
> +++ b/migration/colo.c
> @@ -452,6 +452,9 @@ static int colo_do_checkpoint_transaction(MigrationState
> *s,
> bql_unlock();
> goto out;
> }
> +
> + qemu_savevm_maybe_send_switchover_start(s->to_dst_file);
> +
> /* Note: device state is saved into buffer */
> ret = qemu_save_device_state(fb);
Looks all good, except I'm not sure whether we should touch colo. IIUC it
should be safer to remove it.
--
Peter Xu
- Re: [PATCH v3 05/24] migration: Add MIG_CMD_SWITCHOVER_START and its load handler,
Peter Xu <=