Re: [PATCH 3/7] gitlab: clean packages in cirrus tasks

[Thomas Huth]

On 05/12/2024 10.19, Daniel P. Berrangé wrote:
> On Thu, Dec 05, 2024 at 09:58:54AM +0100, Thomas Huth wrote:
> > On 04/12/2024 20.48, Daniel P. Berrangé wrote:
> > > The FreeBSD VM is somewhat low on disk space after all QEMU build deps
> > > are installed and a full QEMU build performed. Purging the package
> > > manager cache is a simple thing that reclaims about 1 GB of space.
> > >
> > > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> > > ---
> > >    .gitlab-ci.d/cirrus.yml       | 2 ++
> > >    .gitlab-ci.d/cirrus/build.yml | 1 +
> > >    2 files changed, 3 insertions(+)
> > >
> > > diff --git a/.gitlab-ci.d/cirrus.yml b/.gitlab-ci.d/cirrus.yml
> > > index 16411f3d2b..2bd3cb35c9 100644
> > > --- a/.gitlab-ci.d/cirrus.yml
> > > +++ b/.gitlab-ci.d/cirrus.yml
> > > @@ -42,6 +42,7 @@ x64-freebsd-14-build:
> > >        CIRRUS_VM_RAM: 8G
> > >        UPDATE_COMMAND: pkg update; pkg upgrade -y
> > >        INSTALL_COMMAND: pkg install -y
> > > +    CLEAN_COMMAND: pkg clean -y --all
> > >        CONFIGURE_ARGS: 
> > > --target-list-exclude=arm-softmmu,i386-softmmu,microblaze-softmmu,mips64el-softmmu,mipsel-softmmu,mips-softmmu,ppc-softmmu,sh4eb-softmmu,xtensa-softmmu
> > >        TEST_TARGETS: check
> > > @@ -54,6 +55,7 @@ aarch64-macos-build:
> > >        CIRRUS_VM_IMAGE_NAME: ghcr.io/cirruslabs/macos-runner:sonoma
> > >        UPDATE_COMMAND: brew update
> > >        INSTALL_COMMAND: brew install
> > > +    CLEAN_COMMAND: brew cleanup --prune=all
> >
> > Are we also short on disk space in the macOS jobs? Otherwise, I wonder
> > whether we should rather skip the step here to save some seconds of run
> > time?
>
> I've not measured it, but I've not seen disk space issues on macOS. Still
> this command is quick and lost in the noise of the package install process
> which will vary depending on network performance and homebrew server load.

Ok, fair, so if it is a quick command:

Reviewed-by: Thomas Huth <thuth@redhat.com>