[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH-for-9.2? v2 1/2] hw/display/vga: Do not reset 'big_endian_fb'
|
From: |
Gerd Hoffmann |
|
Subject: |
Re: [PATCH-for-9.2? v2 1/2] hw/display/vga: Do not reset 'big_endian_fb' in vga_common_reset() |
|
Date: |
Fri, 6 Dec 2024 10:28:54 +0100 |
On Fri, Dec 06, 2024 at 10:00:37AM +1100, Benjamin Herrenschmidt wrote:
> On Tue, 2024-12-03 at 11:51 +0100, Gerd Hoffmann wrote:
> >
> > The only case I'm aware of where the byte order is actually switched is
> > booting a ppc64le guest in a pseries machine, where the opal firmware
> > runs in bigendian mode and the linux kernel runs in little endian mode.
> >
> > So here the changed reset behavior could actually make a difference, but
> > you will only notice if the opal firmware does *not* set the byte order
> > register.
>
> OPAL (well skiboot) doesn't display anything anyways (or at least it
> didn't when I wrote it :-). It just boots Linux as a bootloader. So as
> long as Linux itself sets the register it should be fine.
Oh, mixed up the firmware names, it's SLOF not OPAL.
sorry for the confusion,
Gerd