[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 00/10] vfio/igd: Enable legacy mode on more devices
From: |
Alex Williamson |
Subject: |
Re: [PATCH v4 00/10] vfio/igd: Enable legacy mode on more devices |
Date: |
Fri, 6 Dec 2024 09:07:59 -0700 |
On Fri, 6 Dec 2024 20:27:38 +0800
Tomita Moeko <tomitamoeko@gmail.com> wrote:
> This patchset extends the support of legacy mode igd passthrough to
> all Intel Gen 11 and 12 devices (including Ice Lake, Jasper Lake,
> Rocket Lake, Alder Lake and Raptor Lake), and emulates GGC register
> in MMIO BAR0 for better compatibiltiy (It is tested Windows and GOP
> driver will read this MMIO register).
>
> It also replaces magic numbers with macros to improve readability,
> and aligns behavior (BDSM registor mirroring and GGMS calculation for
> gen7) with i915 driver to avoid possible issues.
>
> The x-igd-gms option removed in 971ca22f041b ("vfio/igd: don't set
> stolen memory size to zero") is also added back so that data stolen
> memory size can be specified for guest. It is tested that GMS may
> related to framebuffer size, a small GMS value may cause display issues
> like blackscreen. It can be changed by DVMT Pre-allocated option in
> host BIOS, but not all BIOS comes with this option. Having it in QEMU
> helps resolves such issues.
>
> This patchset was verified on Intel i9-12900K CPU(UHD 770, 8086:4680)
> with custom OVMF firmware [1] and IntelGopDriver extracted from host
> bios. IGD device works well in both Windows and Linux guests, and
> scored 726 in 3DMark Time Spy Graphics on Windows guest.
>
> [1] https://github.com/tomitamoeko/edk2/commits/igd-pt-adl/
>
> Btw, IO BAR4 seems never be used by guest, and it the IO BAR itself
> is not working on Gen11+ devices in my experiments. There is no hints
> about that in old commit message and mailing list. It would be greatly
> appreciated if someone shares the background.
>
> Changelog:
> v4:
> * Move "vfio/igd: fix GTT stolen memory size calculation for gen 8+" to
> the first.
> Link:
> 20241205105535.30498-1-tomitamoeko@gmail.com/">https://lore.kernel.org/qemu-devel/20241205105535.30498-1-tomitamoeko@gmail.com/
Series:
Reviewed-by: Alex Williamson <alex.williamson@redhat.com>
- [PATCH v4 02/10] vfio/igd: remove unsupported device ids, (continued)
- [PATCH v4 02/10] vfio/igd: remove unsupported device ids, Tomita Moeko, 2024/12/06
- [PATCH v4 03/10] vfio/igd: align generation with i915 kernel driver, Tomita Moeko, 2024/12/06
- [PATCH v4 04/10] vfio/igd: canonicalize memory size calculations, Tomita Moeko, 2024/12/06
- [PATCH v4 06/10] vfio/igd: add Alder/Raptor/Rocket/Ice/Jasper Lake device ids, Tomita Moeko, 2024/12/06
- [PATCH v4 05/10] vfio/igd: add Gemini Lake and Comet Lake device ids, Tomita Moeko, 2024/12/06
- [PATCH v4 08/10] vfio/igd: emulate GGC register in mmio bar0, Tomita Moeko, 2024/12/06
- [PATCH v4 07/10] vfio/igd: add macro for declaring mirrored registers, Tomita Moeko, 2024/12/06
- [PATCH v4 10/10] vfio/igd: add x-igd-gms option back to set DSM region size for guest, Tomita Moeko, 2024/12/06
- [PATCH v4 09/10] vfio/igd: emulate BDSM in mmio bar0 for gen 6-10 devices, Tomita Moeko, 2024/12/06
- Re: [PATCH v4 00/10] vfio/igd: Enable legacy mode on more devices, Cédric Le Goater, 2024/12/06
- Re: [PATCH v4 00/10] vfio/igd: Enable legacy mode on more devices,
Alex Williamson <=
- Re: [PATCH v4 00/10] vfio/igd: Enable legacy mode on more devices, Cédric Le Goater, 2024/12/06