[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 08/31] acpi/ghes: don't check if physical_address is not zero
From: |
Mauro Carvalho Chehab |
Subject: |
[PATCH 08/31] acpi/ghes: don't check if physical_address is not zero |
Date: |
Fri, 6 Dec 2024 18:12:30 +0100 |
The 'physical_address' value is a faulty page. As such, 0 is
as valid as any other value.
Suggested-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
---
hw/acpi/ghes.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/hw/acpi/ghes.c b/hw/acpi/ghes.c
index edc74c38bf8a..a3dffd78b012 100644
--- a/hw/acpi/ghes.c
+++ b/hw/acpi/ghes.c
@@ -400,10 +400,6 @@ int acpi_ghes_record_errors(uint16_t source_id, uint64_t
physical_address)
start_addr = le64_to_cpu(ags->ghes_addr_le);
- if (!physical_address) {
- return -1;
- }
-
start_addr += source_id * sizeof(uint64_t);
cpu_physical_memory_read(start_addr, &error_block_addr,
--
2.47.1
- [PATCH 00/31] Prepare GHES driver to support error injection, Mauro Carvalho Chehab, 2024/12/06
- [PATCH 02/31] acpi/ghes: simplify acpi_ghes_record_errors() code, Mauro Carvalho Chehab, 2024/12/06
- [PATCH 04/31] acpi/ghes: better handle source_id and notification, Mauro Carvalho Chehab, 2024/12/06
- [PATCH 06/31] acpi/ghes: Remove a duplicated out of bounds check, Mauro Carvalho Chehab, 2024/12/06
- [PATCH 05/31] acpi/ghes: Fix acpi_ghes_record_errors() argument, Mauro Carvalho Chehab, 2024/12/06
- [PATCH 15/31] acpi/ghes: add a firmware file with HEST address, Mauro Carvalho Chehab, 2024/12/06
- [PATCH 01/31] acpi/ghes: get rid of ACPI_HEST_SRC_ID_RESERVED, Mauro Carvalho Chehab, 2024/12/06
- [PATCH 11/31] acpi/ghes: don't crash QEMU if ghes GED is not found, Mauro Carvalho Chehab, 2024/12/06
- [PATCH 08/31] acpi/ghes: don't check if physical_address is not zero,
Mauro Carvalho Chehab <=
- [PATCH 17/31] acpi/generic_event_device: Update GHES migration to cover hest addr, Mauro Carvalho Chehab, 2024/12/06
- [PATCH 10/31] acpi/ghes: better name GHES memory error function, Mauro Carvalho Chehab, 2024/12/06
- [PATCH 12/31] acpi/ghes: rename etc/hardware_error file macros, Mauro Carvalho Chehab, 2024/12/06
- [PATCH 03/31] acpi/ghes: simplify the per-arch caller to build HEST table, Mauro Carvalho Chehab, 2024/12/06
- [PATCH 07/31] acpi/ghes: Change the type for source_id, Mauro Carvalho Chehab, 2024/12/06
- [PATCH 31/31] FIXME: acpi/ghes: properly set data record size, Mauro Carvalho Chehab, 2024/12/06
- [PATCH 19/31] acpi/ghes: add a notifier to notify when error data is ready, Mauro Carvalho Chehab, 2024/12/06
- [PATCH 23/31] scripts/ghes_inject: add a script to generate GHES error inject, Mauro Carvalho Chehab, 2024/12/06