Re: [RFC PATCH] hw/net/can: clean-up unnecessary includes

[Pavel Pisa]

Hello Alex,

On Monday 09 of December 2024 11:06:35 Alex Bennée wrote:
> The event_notifier, thread and socket includes look like copy and
> paste of standard headers. None of the canbus devices use chardev
> although some relied on chardev to bring in bitops and byte swapping
> headers. In this case include them directly.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

Acked-by: Pavel Pisa <pisa@cmp.felk.cvut.cz>

Tested on Debian/GNU/Linux for SJA1000 and CTU CAN FD 

QEMU=/home/pi/repo/qemu/qemu-build/qemu-system-x86_64

$QEMU -enable-kvm -kernel $KERNEL \
      -m 512M \
      -initrd ramdisk.cpio \
      -virtfs local,path=shareddir,security_model=none,mount_tag=shareddir \
      -vga cirrus \
      -append "console=ttyS0 \
      -object can-bus,id=canbus0-bus \
      -object 
can-host-socketcan,if=can0,canbus=canbus0-bus,id=canbus0-socketcan \
      -device kvaser_pci,canbus=canbus0-bus \
      -device ctucan_pci,canbus0=canbus0-bus,canbus1=canbus0-bus \
      -nographic

By the way, I would like to discuse how to update CTU CAN FD a SJA1000
IRQ handling to allow mapping on FPGA target platform buses from command
line.

I have some working prototype

  https://github.com/ppisa/qemu/commits/net-can-ctucanfd-platform/

but I have some questions how to implement interrupts processing
(or logic function) correct and acceptable way. I wills tart new
thread and hope somebody responses and teaches me what is the
proper solution.

Best wishes,

                Pavel
-- 
                Pavel Pisa
    phone:      +420 603531357
    e-mail:     pisa@cmp.felk.cvut.cz
    Department of Control Engineering FEE CVUT
    Karlovo namesti 13, 121 35, Prague 2
    university: http://control.fel.cvut.cz/
    personal:   http://cmp.felk.cvut.cz/~pisa
    social:     https://social.kernel.org/ppisa
    projects:   https://www.openhub.net/accounts/ppisa
    CAN related:http://canbus.pages.fel.cvut.cz/
    RISC-V education: https://comparch.edu.cvut.cz/
    Open Technologies Research Education and Exchange Services
    https://gitlab.fel.cvut.cz/otrees/org/-/wikis/home